Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convention test to ensure pagination methods meet naming conventions #771

Merged
merged 4 commits into from
Apr 6, 2015

Conversation

hnrkndrssn
Copy link
Contributor

  • Convention Test
  • Update all methods that failed the convention test
  • Breaking changes all around :neckbeard:
  • [ ] [:cherries: on top] Convention test to include Observable clients...this would be caught in the SyncObservableInterfaces test though...so might not be urgently needed.

Fixes #767 #768 #769 #770 #772

@hnrkndrssn
Copy link
Contributor Author

Nice little sample of what errors for this convention test will look like 😬 https://ci.appveyor.com/project/Haacked15676/octokit-net/build/1.0.847/tests

@hnrkndrssn hnrkndrssn changed the title [WIP] Add convention test to ensure pagination methods meet naming conventions Add convention test to ensure pagination methods meet naming conventions Mar 23, 2015
@hnrkndrssn
Copy link
Contributor Author

As long as AppVeyor gives me a nice green ✅ this is ready for review

cc @shiftkey

@shiftkey
Copy link
Member

this would be caught in the SyncObservableInterfaces test though...so might not be urgently needed.

That was my thinking on this too. I think we can drop this unless there's another reason to test the observable interfaces explicitly...

@hnrkndrssn
Copy link
Contributor Author

Dropped 😃

@shiftkey
Copy link
Member

shiftkey commented Apr 6, 2015

Thanks heaps for working through this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IEventsClient doesn't follow naming conventions
2 participants