Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEventsClient doesn't follow naming conventions #767

Closed
shiftkey opened this issue Mar 22, 2015 · 0 comments · Fixed by #771
Closed

IEventsClient doesn't follow naming conventions #767

shiftkey opened this issue Mar 22, 2015 · 0 comments · Fixed by #771
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

These methods all paginate - as per #760 they should be renamed to start with GetAll:

  • IEventsClient.GetUserReceived -> GetAllReceived
  • IEventsClient.GetUserReceivedPublic -> GetAllReceivedPublic
  • IEventsClient.GetUserPerformed -> GetAllPerformed
  • IEventsClient.GetUserPerformedPublic -> GetAllPerformedPublic
  • IEventsClient.GetForAnOrganization -> GetAllForOrganization

You might have even better suggestions.
@shiftkey shiftkey mentioned this issue Mar 22, 2015
Merged
13 tasks
@hnrkndrssn hnrkndrssn mentioned this issue Mar 23, 2015
Merged
3 tasks
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add convention test to ensure pagination methods meet naming conventions hnrkndrssn/octokit.net
2 participants
@nickfloyd @shiftkey