stand alone reaction client #1335
Conversation
…ue-reactions-client
add api fix GetAllMethod fix ApiOptions
…-alone-reaction-client
| await Assert.ThrowsAsync<ArgumentException>(() => client.CommitComments.CreateReaction("", "name", 1, new NewReaction(ReactionType.Heart))); | ||
| await Assert.ThrowsAsync<ArgumentNullException>(() => client.CommitComments.CreateReaction("owner", null, 1, new NewReaction(ReactionType.Heart))); | ||
| await Assert.ThrowsAsync<ArgumentException>(() => client.CommitComments.CreateReaction("owner", "", 1, new NewReaction(ReactionType.Heart))); | ||
| } |
There was a problem hiding this comment.
You check if NewReaction is null, so probably want to have a test here on that as well
|
Some nitpicking on the tests, but otherwise looks clean enough. I just have some an itch to try and make a generic solution, but I don't think it will end up looking too nice. |
| @@ -1,4 +1,5 @@ | |||
| using System; | |||
| using Octokit; | |||
There was a problem hiding this comment.
I have a strange behavior in visual studio. Vsual Studio tells me that it cannot resolve typ or namespace for types that came from namespace Octokit. But that comes first since yesterday.
So yes, this was inadvertent.
|
2 integration tests failed for me when creating comments on issues, need to use |
|
Sorry for the grammatical errors |
…-alone-reaction-client
|
No need to apologise! 😀 There was actually a few more places I found, I sent a PR to your branch. Once that's merged I think we are 💎 and ready to merge! |
|
I dont know what is up with TravisCI i've retried like 10 times and always gets the same error. But it's not anything to do with this PR specifically since other PRs are getting the same error. So either it's something that's been merged to master (pretty sure I havent merged anything that didnt pass all builds though) or else travis has some kind of consistent issue... Any ideas @shiftkey ? |
|
@ryangribble not sure, gonna look into it today now I have some bandwidth |
|
@ryangribble I can see a bunch of failures with the common thread being the use of Mono 4.4.0 - which came out a couple of weeks ago. Looking into whether I can choose a specific version and verify this is a regression... |
|
I'm pretty sure #1376 is The |
…-alone-reaction-client
|
😸 |
|
With the 0.20 release 🚢 'ed and the travis issues resolved, it's finally time to merge this puppy! Good work @maddin2016 congratulations on your first major contribution! It's been a bit of a drawn out one this time around but hopefully it's been a good experience 👍 |
|
🎉 🎉 🎉 |
|
I have known about this site for years and u destroyed me |
First preview of an stand alone reaction client. Initially only for commit comments. I created this branch from #1325.
Fixes #1299 #1300 #1301 #1302 #1303