lock to an earlier version of mono #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks for this, I was scratching my head being unfamiliar with cross platform stuff |
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
alexander-efremov
pushed a commit
to alexander-efremov/octokit.net
that referenced
this pull request
Jun 14, 2016
|
Thanks! I've rebased my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis is currently in an interesting spot where
latestmeans it'll use Mono 4.4.0 when building and testing on OS X, and 4.2.3 when building and testing on Linux.Unfortunately this means the OS X builds are exhibiting some strange behaviour:
BuildMonostep* Assertion at metadata.c:3643, condition 'ptr' not metwhen running the PCL testsExample build output: https://travis-ci.org/octokit/octokit.net/jobs/137385011
I found the flag to force a specific version of Mono for both platforms, and that seems to do the trick here.
@dampir @ErikSchierboom @shaggygi @alfhenrik @maddin2016 I think you're all encountering this on your PRs, feel free to merge
masteror cherry-pick this commit into your branch after I confirm this resolves the issue.