Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a Reaction #1303

Closed
shiftkey opened this issue May 17, 2016 · 1 comment
Closed

Delete a Reaction #1303

shiftkey opened this issue May 17, 2016 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Milestone
Reactions Support

Comments

@shiftkey
Copy link
Member

Link: https://developer.github.com/v3/reactions/#delete-a-reaction

As this is a standalone API not tied to specific resources, this should live in a new IReactionsClient (with an equivalent IObservableReactionsClient for Octokit.Reactive) as a property of the root IGitHubClient.

It only needs one method at this stage, which returns a Task (or IObservable<Unit>) but you'll need to send the new preview header along with it: application/vnd.github.squirrel-girl-preview

  • DELETE /reactions/:id
@martinscholz83 martinscholz83 mentioned this issue May 26, 2016
Closed
1 task
@martinscholz83 martinscholz83 mentioned this issue Jun 8, 2016
Merged
@shiftkey shiftkey modified the milestone: Reactions Support Jun 14, 2016
@ryangribble
Copy link
Contributor

fixed by #1335

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
Reactions Support
Development

No branches or pull requests
3 participants
@nickfloyd @shiftkey @ryangribble