Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create reaction for pull request comment #1299

Closed
shiftkey opened this issue May 17, 2016 · 0 comments
Closed

create reaction for pull request comment #1299

shiftkey opened this issue May 17, 2016 · 0 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

shiftkey commented May 17, 2016

Link: https://developer.github.com/v3/reactions/#create-reaction-for-a-pull-request-review-comment

This is a new endpoint which should live in IPullRequestReviewCommentClient

POST /repos/:owner/:repo/pulls/comments/:id/reactions

Example request payload:

{
  "content": "heart"
}

As these are a limited subset of emojis, the request object should use an enumeration of values - rather than a regular string.

Example response payload:

{
  "id": 1,
  "user_id": 1,
  "content": "heart"
}
  • define classes for payload in Octokit project and .\build FixProjects to make them available everywhere
  • add new method to IReactionClient
  • add new method to IObservableReactionClient
  • implement both interfaces and ensure preview header is sent: application/vnd.github.squirrel-girl-preview
  • unit tests to verify behaviour
  • integration test to confirm code works against real API
@shiftkey shiftkey modified the milestone: Reactions Support Jun 14, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants