Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to material icons #38

Closed
7 tasks done
ChristophWurst opened this issue May 17, 2022 · 8 comments
Closed
7 tasks done

Migrate to material icons #38

ChristophWurst opened this issue May 17, 2022 · 8 comments
Assignees
@GretaD
Labels
4. to release Ready to be released and/or waiting for tests to finish overview Overview of other issues

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented May 17, 2022 •
edited
Loading

Describe the task

Nextcloud 25 has a hard breaking change and we need to change our icons for it nextcloud/server#32060

Affected components

To do
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of overview Overview of other issues labels May 17, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team May 17, 2022
This was referenced May 17, 2022
Closed
Closed
Merged
Merged
This was referenced May 27, 2022
Closed
Merged
Closed
Closed
@ChristophWurst ChristophWurst moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team May 30, 2022
@GretaD GretaD mentioned this issue May 31, 2022
Merged
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jun 1, 2022
This was referenced Jun 10, 2022
Merged
Merged
Merged
@ChristophWurst
Copy link
Member Author

How far are we with this migration @GretaD?

@GretaD
Copy link
Contributor

GretaD commented Jun 27, 2022

How far are we with this migration @GretaD?

99% for mail, there are only 2 open PRs, i did a general test last week and i think thats all we have to migrate here(one pr is blocked)
On calendar i think its all done, but i havent test it yet like i did with mail to see if i missed smth.
Contacts, i havent started yet.

If you need an ETA, i can finish all this week (but the blocked PR).

This was referenced Jun 29, 2022
Closed
Merged
@ChristophWurst
Copy link
Member Author

https://github.com/nextcloud/calendar-availability-vue/blob/main/src/CalendarAvailability.vue also uses two icon-* classes that need replacing

@ChristophWurst ChristophWurst mentioned this issue Jun 29, 2022
Merged
This was referenced Jun 29, 2022
Merged
Closed
Merged
Closed
@GretaD GretaD mentioned this issue Jun 29, 2022
Merged
This was referenced Jul 13, 2022
Merged
Merged
Merged
@GretaD
Copy link
Contributor

GretaD commented Jul 13, 2022 •
edited
Loading

Mail

Note: These can be done only after vue loading icon is released

@ChristophWurst ChristophWurst mentioned this issue Jul 15, 2022
Merged
@ChristophWurst ChristophWurst mentioned this issue Aug 8, 2022
Closed
21 tasks
@GretaD
Copy link
Contributor

GretaD commented Aug 9, 2022 •
edited
Loading

To do on contacts with stoppers

  • All the loading icons
  • Icon-add on - AppNavigationCaption used on RootNavigation.vue no icon slot
  • Icon-add on AppNavigationNew used on Contacts.vue - no icon slot

To do but that are leftovers, and will be done in one pr this week

  • icon external on rootnavigation
  • icon-checkmark entitysearchresult
  • icon-group/icon-user line 126 on settingsaddressbookshare
  • icon-history line 105 and icon-errorr on contactdetails

@GretaD
Copy link
Contributor

GretaD commented Aug 9, 2022 •
edited by ChristophWurst
Loading

To do on contacts, no stoppers

  • icon-add on checkavailibility
  • icon-group/icon-user/icon-circle calendarlistitemsharingsearch
  • Icon-add on AppNavigationItem used on calendarlistnew
  • icons on avatarparticipationstatus

@ChristophWurst ChristophWurst mentioned this issue Aug 16, 2022
Merged
5 tasks
This was referenced Sep 5, 2022
Closed
Merged
Closed
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 8, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 8, 2022
@GretaD GretaD mentioned this issue Sep 8, 2022
Merged
@ChristophWurst
Copy link
Member Author

nextcloud/contacts#2960 misses an icon upgrade.

@ChristophWurst
Copy link
Member Author

Bildschirmfoto vom 2022-10-10 12-36-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GretaD GretaD

Labels
4. to release Ready to be released and/or waiting for tests to finish overview Overview of other issues
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristophWurst @GretaD