-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Primary action icons #6568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. I left some feedback and pushed a small commit to make the new important icon a bit more consistent with material icon components.
2406eb5
to
bca5ff3
Compare
Fixed, also filled the gold colour for favorite. |
We can fine tune after the design review |
You are right, but the design material forces the icons to be always on the center. I just moved the text to be more up, i didnt redesign the way how the design icons looks. |
Signed-off-by: greta <[email protected]>
b0e35b8
to
fbf2f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greta, i have finally found the icon https://fonts.google.com/icons?selected=Material+Icons&icon.query=important =)
but it seems that there is not vue component for it, am i right?
It is not in https://materialdesignicons.com/ |
This is the basis for https://www.npmjs.com/package/vue-material-design-icons. I'm not sure if we can use Google's icon if it's not in there. |
ref nextcloud/groupware#38
Our important icon is a customized one, i created a new component following the logic here: https://github.com/nextcloud/spreed/blob/b06c7f24886e6773219aa60d93e27ee1bb9f59d8/src/components/missingMaterialDesignIcons/PresentToAll.vue