Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EmptyContent contacts icons to material design #2799

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 28, 2022

it was changed icons from emptycontent for contacts and second column button when in mobile size
contactmobile

Ref nextcloud/groupware#38

@GretaD GretaD added the 2. developing Work in progress label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #2799 (0af23a5) into main (c53a982) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2799      +/-   ##
============================================
- Coverage     18.23%   17.99%   -0.24%     
  Complexity      253      253              
============================================
  Files            98       99       +1     
  Lines          3187     3229      +42     
  Branches        440      449       +9     
============================================
  Hits            581      581              
- Misses         2413     2454      +41     
- Partials        193      194       +1     
Impacted Files Coverage Δ
src/components/AppContent/ContactsContent.vue 0.00% <ø> (ø)
src/components/ContactDetails.vue 0.00% <ø> (ø)
src/components/MemberList.vue 0.00% <ø> (ø)
src/store/circles.js 4.25% <0.00%> (-0.24%) ⬇️
src/components/CircleDetails.vue 0.00% <0.00%> (ø)
...omponents/CircleDetails/CirclePasswordSettings.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53a982...0af23a5. Read the comment docs.

@GretaD GretaD changed the title Migrate EmptyContent icons to material design Migrate EmptyContent contacts icons to material design Jun 28, 2022
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 29, 2022
@GretaD GretaD marked this pull request as ready for review June 29, 2022 10:52
@ChristophWurst ChristophWurst merged commit f6b7c6d into main Jun 29, 2022
@ChristophWurst ChristophWurst deleted the migrate/icons-to-material-design branch June 29, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants