-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate composer action menu icons to material design icons + migrate to Vue buttons #6871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you rename button
to Button
? the nc/vue button component is imported as VButton
Are the button changes even necessary for the icon replacement?
no there are not necessary on this pr because < button > doesnt have an icon. When it has an icon then it needs < Button >. I did it here because ive done it with other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐘
Signed-off-by: greta <[email protected]>
69f3463
to
91d9303
Compare
There is quite a bit of chaos with the buttons now, you have
mail/src/components/Composer.vue Lines 61 to 67 in 57ffa52
mail/src/components/Composer.vue Lines 355 to 363 in 57ffa52
mail/src/components/Composer.vue Lines 377 to 379 in 57ffa52
|
ref nextcloud/groupware#38