Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate timezone and calendar icon #4268

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 10, 2022

@GretaD GretaD added the 2. developing Work in progress label Jun 10, 2022
@GretaD GretaD self-assigned this Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #4268 (0215d20) into main (cd7b85d) will increase coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 0215d20 differs from pull request most recent head a791d74. Consider uploading reports for the commit a791d74 to get more accurate results

@@             Coverage Diff              @@
##               main    #4268      +/-   ##
============================================
+ Coverage     29.43%   29.56%   +0.13%     
  Complexity      330      330              
============================================
  Files           221      221              
  Lines          7706     7658      -48     
  Branches       1020     1013       -7     
============================================
- Hits           2268     2264       -4     
+ Misses         5438     5394      -44     
Flag Coverage Δ
javascript 20.65% <0.00%> (+0.11%) ⬆️
php 68.75% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/Editor/FreeBusy/FreeBusy.vue 0.00% <ø> (ø)
src/components/Shared/DatePicker.vue 0.00% <0.00%> (ø)
src/store/settings.js 94.17% <0.00%> (-0.06%) ⬇️
src/views/Calendar.vue 0.00% <0.00%> (ø)
src/views/EditSimple.vue 0.00% <0.00%> (ø)
src/mixins/EditorMixin.js 0.00% <0.00%> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
...ud/apps/calendar/lib/Controller/ViewController.php 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7b85d...a791d74. Read the comment docs.

@GretaD GretaD marked this pull request as ready for review June 15, 2022 14:53
@GretaD GretaD requested review from st3iny and ChristophWurst June 15, 2022 14:53
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 15, 2022
src/components/Shared/DatePicker.vue Outdated Show resolved Hide resolved
src/components/Shared/DatePicker.vue Outdated Show resolved Hide resolved
@GretaD GretaD force-pushed the migrate/icons-material-design branch from 3f1fd23 to db5492d Compare June 15, 2022 15:40
@GretaD GretaD requested a review from tcitworld June 15, 2022 15:41
@GretaD GretaD requested a review from tcitworld June 15, 2022 15:55
@GretaD GretaD force-pushed the migrate/icons-material-design branch from 0215d20 to a791d74 Compare June 21, 2022 13:31
@GretaD GretaD merged commit 71a95dd into main Jun 21, 2022
@GretaD GretaD deleted the migrate/icons-material-design branch June 21, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

3 participants