Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrences have a save button that doesn't have a clear function #4094

Closed
miaulalala opened this issue Mar 21, 2022 · 15 comments
Closed

Recurrences have a save button that doesn't have a clear function #4094

miaulalala opened this issue Mar 21, 2022 · 15 comments
Labels
1. to develop Accepted and waiting to be taken care of bug nextcloud-gmbh Tickets with importance for Nextcloud Gmbh

Comments

@miaulalala
Copy link
Contributor

miaulalala commented Mar 21, 2022

Steps to reproduce

  1. Open an event and add a recurrence:

save

Expected behavior

A visible save button that works and lets me add a second reminder

Actual behaviour

The button removes the reminder even though the hint says "save".

Calendar app version

3.2.2

CalDAV-clients used

Web

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

No response

Database engine version

No response

PHP engine version

No response

Nextcloud version

No response

Updated from an older installed version or fresh install

No response

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

@miaulalala miaulalala added bug 0. to triage Pending approval or rejection 1. to develop Accepted and waiting to be taken care of nextcloud-gmbh Tickets with importance for Nextcloud Gmbh and removed 0. to triage Pending approval or rejection labels Mar 21, 2022
@ChristophWurst
Copy link
Member

Before I add a reminder
Bildschirmfoto von 2022-03-21 18-25-47

After I've added a reminder
Bildschirmfoto von 2022-03-21 18-25-53

The Update button is at the bottom. But I don't see a button Save. The action you hover is the recurrence Edit action, right?

@miaulalala miaulalala changed the title Reminders have a save buttion that doesn't have a clear function Recurrences have a save button that doesn't have a clear function Mar 21, 2022
@miaulalala
Copy link
Contributor Author

Sorry, of course it's the recurrence. Looks like the button outline still shows even though the edit button disappears.

The tooltip also shows the text "Save" as shown in the screenshot above.

@ChristophWurst
Copy link
Member

@GretaD could you have a look please?

@GretaD
Copy link
Contributor

GretaD commented Jun 1, 2022

I can reproduce the error but it doesnt look exactly like Anna's screenshot
2buttonssave

I have a working "save" button on top right but when i click end repeat on a certain date, a second button pops ups that doesnt do anything and that i cannot find it on the code 😐
will have a double look soon

@ChristophWurst
Copy link
Member

v3.3.1 (production)

Bildschirmfoto vom 2022-06-01 16-39-40

v3.4.0 (dev)

Bildschirmfoto vom 2022-06-01 16-39-12

So I can neither reproduce the original bug nor your floating button.

@GretaD
Copy link
Contributor

GretaD commented Jun 1, 2022

change the end repeat to "on date"

@GretaD
Copy link
Contributor

GretaD commented Jun 1, 2022

on our cloud has this icon
confirmedrec

@ChristophWurst
Copy link
Member

Bildschirmfoto vom 2022-06-01 16-43-20

right

@GretaD
Copy link
Contributor

GretaD commented Jun 1, 2022

so its not a saving button, its the calendar icon. The saving button is the first one only, thats why i dont find it on the code

@ChristophWurst
Copy link
Member

Due to nextcloud/server#32072 the calendar icon vanished

@ChristophWurst
Copy link
Member

@miaulalala has to re-check the problem. https://github.com/nextcloud/calendar/blame/main/src/components/Editor/Repeat/Repeat.vue has been a material icon for a while and the checkmark shows for both of us.

@miaulalala
Copy link
Contributor Author

Right, I don't know why but I do not have the calendar icon in Chrome:

image

I force cleared the npm cache and did npm ci && npm run build with the browser cache disabled in Chrome.

also, what's the purpose of the icon anyway? Does it have an action attached for you @ChristophWurst @GretaD ? For me it doesn't trigger anything.

@GretaD
Copy link
Contributor

GretaD commented Jun 10, 2022

also, what's the purpose of the icon anyway? Does it have an action attached for you @ChristophWurst @GretaD ? For me it doesn't trigger anything.

The icon itself should be migrated to material design thats why it doesnt show, im already working on it
But can you reproduce your initial scenario?

@GretaD
Copy link
Contributor

GretaD commented Jun 10, 2022

WHile on this pr: #4268
it looks like this:

saverecur

@miaulalala
Copy link
Contributor Author

Right, the original save button is now fully functional. As the calendar icon not showing is a know issue that is being fixed, I will close this ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug nextcloud-gmbh Tickets with importance for Nextcloud Gmbh
Projects
None yet
Development

No branches or pull requests

3 participants