Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtual disks tab on virtual machine view not showing for non-superadmins #15668

Closed
ITJamie opened this issue Apr 9, 2024 · 3 comments · Fixed by #15707
Closed

virtual disks tab on virtual machine view not showing for non-superadmins #15668

ITJamie opened this issue Apr 9, 2024 · 3 comments · Fixed by #15707
Assignees
@Julio-Oliveira-Encora
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@ITJamie
Copy link
Contributor

ITJamie commented Apr 9, 2024 •
edited
Loading

Deployment Type

NetBox internal

NetBox Version

v.3.7.5

Python Version

3.11

Steps to Reproduce

1: create a new permission set with all permissions enabled across all objects
2: create a new user and add that permission set
3: login as the new user.
4: create a VM

  • on the VM view page. the virtual disks tab will be missing

5: increase the users permission to superuser

  • on the VM view page logged in as the new user the virtual disks tab will appear

Expected Behavior

that virtual disks tab was visible on the VM view for users with permissions

Observed Behavior

virtual disk tab did not show.
@ITJamie ITJamie added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 9, 2024
@ITJamie
Copy link
Contributor Author

ITJamie commented Apr 9, 2024 •
edited
Loading

without superuser role
without superuser

with superuser role
with superuser

permissions that were attached:
permissions

@jeffgdotorg
Copy link
Contributor

Good catch, @ITJamie. Thanks for the report. I was able to reproduce the issue on a fresh 3.7.5 install.

image

PS I think the deployment type might be incorrect, please double check and edit if appropriate.

@jeffgdotorg jeffgdotorg removed their assignment Apr 10, 2024
@jeffgdotorg jeffgdotorg added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 10, 2024
@arthanson arthanson self-assigned this Apr 11, 2024
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 11, 2024
@Julio-Oliveira-Encora
Copy link
Contributor

Could you please assign it to me?

Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Apr 15, 2024
jeremystretch added a commit that referenced this issue Apr 15, 2024
@jeremystretch
Changelog for #15640, #15644, #15654, #15668, #15685
17e8773
@jeremystretch jeremystretch mentioned this issue Apr 22, 2024
Merged
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@jeremystretch @JCWasmx86
Changelog for netbox-community#15640, netbox-community#15644, netbox-…
02ddea7 
…community#15654, netbox-community#15668, netbox-community#15685
@github-actions github-actions bot mentioned this issue May 1, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Julio-Oliveira-Encora Julio-Oliveira-Encora

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
5 participants
@arthanson @jeffgdotorg @ITJamie @jeremystretch @Julio-Oliveira-Encora