Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add L2VPN identifier field to the search index for L2VPN objects #15640

Closed
rwxd opened this issue Apr 5, 2024 · 3 comments · Fixed by #15673
Closed

Add L2VPN identifier field to the search index for L2VPN objects #15640

rwxd opened this issue Apr 5, 2024 · 3 comments · Fixed by #15673
Assignees
@rwxd
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@rwxd
Copy link
Contributor

rwxd commented Apr 5, 2024 •
edited by jeffgdotorg
Loading

NetBox version

v3.7.4

Feature type

Change to existing functionality

Proposed functionality

Add the identifier field of L2VPN to the corresponding SearchIndex, so that it's possible to enter an L2VPN identifier into the global search and turn up the corresponding L2VPN object in the results.

Use case

We use the identifier field of L2VPN to note a vxlan id.
It would be nice to also see the l2vpn, when we search for the vxlan id.

image

#13927 exists, but the issue was also about making the identifier unique & required.

Database changes

No response

External dependencies

No response
@rwxd rwxd added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Apr 5, 2024
@jeffgdotorg jeffgdotorg changed the title Add identifier to the search index of L2VPN Add L2VPN identifier field to the search index for L2VPN objects Apr 8, 2024
@jeffgdotorg jeffgdotorg added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 8, 2024
@jeffgdotorg
Copy link
Contributor

Thanks for your interest in helping improve NetBox.

I've moved this issue into needs owner status. If you are interested in working it through to a PR, let us know and we'll assign the issue to you. Otherwise, any developer with the skills and capacity can request to work on it.

@rwxd
Copy link
Contributor Author

rwxd commented Apr 8, 2024

Thanks. I'm interested in doing the PR

@jeremystretch jeremystretch assigned rwxd and unassigned jeffgdotorg Apr 9, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 9, 2024
@jeremystretch
Copy link
Member

Thanks @rwxd, I've assigned this to you.

rwxd added a commit to rwxd/netbox that referenced this issue Apr 9, 2024
@rwxd
Closes netbox-community#15640: add identifier field to search index o…
171f04c 
…f l2vpn
rwxd added a commit to rwxd/netbox that referenced this issue Apr 9, 2024
@rwxd
Fixes netbox-community#15640: add identifier field to search index of…
b00d3bc 
… l2vpn
rwxd added a commit to rwxd/netbox that referenced this issue Apr 9, 2024
@rwxd
Fixes netbox-community#15640: add identifier field to search index of…
63226a3 
… l2vpn
@rwxd rwxd mentioned this issue Apr 9, 2024
Merged
jeremystretch pushed a commit that referenced this issue Apr 15, 2024
@rwxd @jeremystretch
Fixes #15640: add identifier field to search index of l2vpn
f7e4fe2
jeremystretch added a commit that referenced this issue Apr 15, 2024
@jeremystretch
Changelog for #15640, #15644, #15654, #15668, #15685
17e8773
@jeremystretch jeremystretch mentioned this issue Apr 22, 2024
Merged
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@rwxd @JCWasmx86
Fixes netbox-community#15640: add identifier field to search index of…
e50798d 
… l2vpn
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@jeremystretch @JCWasmx86
Changelog for netbox-community#15640, netbox-community#15644, netbox-…
02ddea7 
…community#15654, netbox-community#15668, netbox-community#15685
@github-actions github-actions bot mentioned this issue May 1, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rwxd rwxd

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15640: add identifier field to search index of l2vpn rwxd/netbox
3 participants
@jeffgdotorg @jeremystretch @rwxd