[api-minor] Split highlight annotation div into multiple divs #12505
Conversation
There was a problem hiding this comment.
Looks good with these comments addressed. This is most likely related to #6811; note that it applies not only to highlights, but to all markup annotations and link annotations. That can be done in a follow-up though.
Fix for issue mozilla#12504. Highlight annotation may have several rectangles so we must have several divs to add mouse events handlers.
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d49c5ffb1707677/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d49c5ffb1707677/output.txt Total script time: 24.78 mins
Image differences available at: http://54.67.70.0:8877/d49c5ffb1707677/reftest-analyzer.html#web=eq.log |
|
Unfortunately the reference tests above show a regression for |
timvandermeij
changed the title
|
Aside from the things mentioned in follow-up issue #12576, this patch does look exactly like what I would expect code-wise and works fine for the original issue and most other files, so thank you for that! |
* remove 1st param of _createPopup (almost useless for a method) * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events) * add a ref test for issue mozilla#12504
* remove 1st param of _createPopup (almost useless for a method) * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events) * add a ref test for issue mozilla#12504
* remove 1st param of _createPopup (almost useless for a method) * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events) * add a ref test for issue mozilla#12504
* remove 1st param of _createPopup (almost useless for a method) * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events) * add a ref test for issue mozilla#12504
Fix popup for highlights without popup (follow-up of #12505)
This patch aims to fix issue #12504.
Instead of using
Annotation::Rectfor the div dimensions, we use several divs where dimensions are inQuadPointsand then set mouse handlers on each of them.