Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight annotation div can be on top of a textfield #12504

Closed
calixteman opened this issue Oct 21, 2020 · 1 comment
Closed

Highlight annotation div can be on top of a textfield #12504

calixteman opened this issue Oct 21, 2020 · 1 comment
Labels
annotations

Comments

@calixteman
Copy link
Contributor

Attach (recommended) or Link to PDF file here:
plop.pdf

Here the highlight has two rectangles and only Annotation::Rect is used when creating the div in the annotation layer and so the field is almost unusable.
@calixteman calixteman mentioned this issue Oct 21, 2020
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 21, 2020
@calixteman
Split highlight annotation div into multiple divs
9c29a69 
Fix for issue mozilla#12504.
Highlight annotation may have several rectangles so we must have several divs to add mouse events handlers.
calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 23, 2020
@calixteman
Split highlight annotation div into multiple divs
85e6c67 
Fix for issue mozilla#12504.
Highlight annotation may have several rectangles so we must have several divs to add mouse events handlers.
@timvandermeij
Copy link
Contributor

Fixed the PR above.

@timvandermeij timvandermeij mentioned this issue Nov 4, 2020
Closed
calixteman added a commit to calixteman/pdf.js that referenced this issue Nov 5, 2020
@calixteman
Fix popup for highlights without popup (follow-up of mozilla#12505)
47e3fdd 
 * remove 1st param of _createPopup (almost useless for a method)
 * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events)
 * add a ref test for issue mozilla#12504
@calixteman calixteman mentioned this issue Nov 5, 2020
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue Nov 5, 2020
@calixteman
Fix popup for highlights without popup (follow-up of mozilla#12505)
c4bd5e3 
 * remove 1st param of _createPopup (almost useless for a method)
 * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events)
 * add a ref test for issue mozilla#12504
calixteman added a commit to calixteman/pdf.js that referenced this issue Nov 5, 2020
@calixteman
Fix popup for highlights without popup (follow-up of mozilla#12505)
8bfc536 
 * remove 1st param of _createPopup (almost useless for a method)
 * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events)
 * add a ref test for issue mozilla#12504
calixteman added a commit to calixteman/pdf.js that referenced this issue Nov 10, 2020
@calixteman
Fix popup for highlights without popup (follow-up of mozilla#12505)
611207d 
 * remove 1st param of _createPopup (almost useless for a method)
 * prepend popup div to avoid to have them on top of some highlights (and so "disable" partially mouse events)
 * add a ref test for issue mozilla#12504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timvandermeij @calixteman