You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately there was an oversight in PR #12505 where some regressions were missed:
The annotation-highlight-without-appearance, issue7014 and issue9552 reference tests no longer show the popup, and I can confirm that it also doesn't render in the viewer anymore. They most likely share the same root cause.
I have debugged this and found that, at least in the annotation-highlight-without-appearance case, the _createPopup line in HighlightAnnotationElement is triggered. The popup is in fact added to the container, but the annotation also has quadrilaterals and in that case those are returned/rendered and not the container. The problem is therefore limited to annotations without an explicit popup annotation, otherwise it works because that logic queries all quadrilateral elements. Therefore, the solution here seems to be to change _createPopup to also take the quadrilaterals into account, similar to the other code.
The quadrilaterals don't have the proper class name for highlight annotations anymore, causing them not to have a cursor pointer on hover.
I have found the cause of this to be on line 1379 in src/display/annotation_layer.js where the class name is only set on the container and not on all quadrilaterals (because we only had the container before).
Once this is fixed, please add the PDF file from #12504 to the test suite as well to ensure that that case is also still working.
Unfortunately there was an oversight in PR #12505 where some regressions were missed:
annotation-highlight-without-appearance
,issue7014
andissue9552
reference tests no longer show the popup, and I can confirm that it also doesn't render in the viewer anymore. They most likely share the same root cause.annotation-highlight-without-appearance
case, the_createPopup
line inHighlightAnnotationElement
is triggered. The popup is in fact added to the container, but the annotation also has quadrilaterals and in that case those are returned/rendered and not the container. The problem is therefore limited to annotations without an explicit popup annotation, otherwise it works because that logic queries all quadrilateral elements. Therefore, the solution here seems to be to change_createPopup
to also take the quadrilaterals into account, similar to the other code.src/display/annotation_layer.js
where the class name is only set on the container and not on all quadrilaterals (because we only had the container before).Once this is fixed, please add the PDF file from #12504 to the test suite as well to ensure that that case is also still working.
/cc @calixteman
The text was updated successfully, but these errors were encountered: