-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split underline, strikeout, squiggly annotions div into multiple divs #12673
Conversation
calixteman
commented
Dec 1, 2020
- Follow up of [api-minor] Split highlight annotation div into multiple divs #12505
- Fix bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1679696
The user (in bug 1679696) shared privately the PDF and this patch fix the issue. |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a3d455a5e435021/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/ab4a1d60ed3907b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a3d455a5e435021/output.txt Total script time: 25.60 mins
Image differences available at: http://54.67.70.0:8877/a3d455a5e435021/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/ab4a1d60ed3907b/output.txt Total script time: 28.01 mins
Image differences available at: http://3.101.106.178:8877/ab4a1d60ed3907b/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/03ef30fe298b84a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/03ef30fe298b84a/output.txt Total script time: 4.01 mins Published |
Nice work! I actually had this exact same patch stashed locally, but got distracted with another edge case that we need to fix. I'll make a patch for that later which will also include a minimal reference test case for all these annotations, but I can confirm that this patch indeed also fixes the normal cases in that file. /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e90032ff32ada22/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/da4b6db41d92048/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e90032ff32ada22/output.txt Total script time: 24.65 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/da4b6db41d92048/output.txt Total script time: 27.16 mins
|