Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split underline, strikeout, squiggly annotions div into multiple divs #12673

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

The user (in bug 1679696) shared privately the PDF and this patch fix the issue.
The div for strikeout is over the div for some highlights, so splitting them fix the issue.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a3d455a5e435021/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/ab4a1d60ed3907b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a3d455a5e435021/output.txt

Total script time: 25.60 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a3d455a5e435021/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/ab4a1d60ed3907b/output.txt

Total script time: 28.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/ab4a1d60ed3907b/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/03ef30fe298b84a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/03ef30fe298b84a/output.txt

Total script time: 4.01 mins

Published

@timvandermeij
Copy link
Contributor

Nice work! I actually had this exact same patch stashed locally, but got distracted with another edge case that we need to fix. I'll make a patch for that later which will also include a minimal reference test case for all these annotations, but I can confirm that this patch indeed also fixes the normal cases in that file.

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e90032ff32ada22/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/da4b6db41d92048/output.txt

@timvandermeij timvandermeij merged commit db6b67c into mozilla:master Dec 1, 2020
@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e90032ff32ada22/output.txt

Total script time: 24.65 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2020

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/da4b6db41d92048/output.txt

Total script time: 27.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants