Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2]: Sync with master branch #372

Closed
wants to merge 2 commits into from
Closed

[ros2]: Sync with master branch #372

wants to merge 2 commits into from

Conversation

JafarAbdi
Copy link
Member

Please fast-forward merge using CLI

stephanie-eng
stephanie-eng approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@stephanie-eng stephanie-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for helping with this!

@JafarAbdi JafarAbdi mentioned this pull request Jun 15, 2022
Closed
AndyZe
AndyZe reviewed Jun 15, 2022
View reviewed changes
core/test/test_move_to.cpp Outdated Show resolved Hide resolved
core/test/test_move_to.cpp Outdated Show resolved Hide resolved
core/src/solvers/cartesian_path.cpp Show resolved Hide resolved
@JafarAbdi @rhaschke
Fix Task's move constructor (moveit#371)
4c2c38c 
* Add unit test
* Fix TaskPrivate's move assignment operator
* Slightly simplify code

Co-authored-by: Robert Haschke <[email protected]>
@JafarAbdi JafarAbdi requested a review from rhaschke June 15, 2022 14:32
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #372 (4c2c38c) into ros2 (d6284ea) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             ros2     #372      +/-   ##
==========================================
+ Coverage   42.03%   42.11%   +0.09%     
==========================================
  Files          78       78              
  Lines        7767     7768       +1     
==========================================
+ Hits         3264     3271       +7     
+ Misses       4503     4497       -6
Impacted Files Coverage Δ
core/src/solvers/cartesian_path.cpp 85.00% <100.00%> (+0.39%) ⬆️
core/src/task.cpp 63.50% <100.00%> (+1.00%) ⬆️
core/src/introspection.cpp 77.85% <0.00%> (+2.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6284ea...4c2c38c. Read the comment docs.

@rhaschke rhaschke mentioned this pull request Jun 15, 2022
Merged
rhaschke
rhaschke reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contentwise fine. But, please perform merge commits instead of cherry picks to more easily see what was already merged. We did that in the past in this repo as well.
See here: #373

@rhaschke
Copy link
Contributor

Closing in favour of #373.

@rhaschke rhaschke closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZe AndyZe AndyZe left review comments

@rhaschke rhaschke rhaschke left review comments

@stephanie-eng stephanie-eng stephanie-eng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JafarAbdi @rhaschke @stephanie-eng @AndyZe @wyattrees