Fix task's move constructor #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
force-pushed
the
pr-fix_task_move_constructor
branch
from
a02070b to
06d5370
Compare
|
Running |
JafarAbdi
commented
Jun 9, 2022
| @@ -77,7 +77,6 @@ TaskPrivate::TaskPrivate(Task* me, const std::string& ns) | |||
| TaskPrivate& TaskPrivate::operator=(TaskPrivate&& other) { | |||
| this->WrapperBasePrivate::operator=(std::move(other)); | |||
| ns_ = std::move(other.ns_); | |||
| introspection_ = std::move(other.introspection_); | |||
There was a problem hiding this comment.
Maybe I should reset other.introspection_?
There was a problem hiding this comment.
Moving a unique_ptr like this should correctly reset other's introspection_ pointer.
|
Thanks to the Address sanitizer, I was able to fix the bug, introspection hold a pointer to a PrivateTask so when we move the lhs the moved introspection will still point to the deleted task_ causing any call to introspection to access freed memory |
JafarAbdi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 54.55% 54.61% +0.06%
==========================================
Files 102 102
Lines 7852 7851 -1
==========================================
+ Hits 4283 4287 +4
+ Misses 3569 3564 -5
Continue to review full report at Codecov.
|
rhaschke
reviewed
Jun 10, 2022
| @@ -77,7 +77,6 @@ TaskPrivate::TaskPrivate(Task* me, const std::string& ns) | |||
| TaskPrivate& TaskPrivate::operator=(TaskPrivate&& other) { | |||
| this->WrapperBasePrivate::operator=(std::move(other)); | |||
| ns_ = std::move(other.ns_); | |||
| introspection_ = std::move(other.introspection_); | |||
There was a problem hiding this comment.
Moving a unique_ptr like this should correctly reset other's introspection_ pointer.
rhaschke
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Thanks, @JafarAbdi, for tracking this down. Your solution to keep the existing introspection instance was correct in principle. However, if the other task doesn't have introspection enable, we should disable it in the new instance too and vice versa. I added a corresponding fixup.
JafarAbdi
added a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Jun 15, 2022
* Add unit test * Fix TaskPrivate's move assignment operator * Slightly simplify code Co-authored-by: Robert Haschke <[email protected]>
JafarAbdi
added a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Jun 15, 2022
* Add unit test * Fix TaskPrivate's move assignment operator * Slightly simplify code Co-authored-by: Robert Haschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix moveit/moveit2_tutorials#426
Backtrace: