Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Merges redaction log feature to master #2634

Merged
merged 6 commits into from
Oct 4, 2024
Merged

chore: Merges redaction log feature to master #2634

merged 6 commits into from
Oct 4, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Sep 25, 2024 •
edited
Loading

Description

Merges redaction log feature to master

Link to any related issue(s): CLOUDP-274532

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli
feat: Supports redact_client_log_data in `mongodbatlas_advanced_clu…
b9e69e1 
…ster` (#2600)

* use SDK Preview

* add redact_client_log_data to schema

* plural ds

* resource

* tests

* changelog
@lantoli
feat: Supports redact_client_log_data in mongodbatlas_cluster (#2601
7ae52b0 
)

* doc

* changelog

* new atlas functions

* data sources

* resource

* tests

* rename CRUD functions

* wait for cluster changes

* apply feedback for changelog

* use acc.CheckRSAndDS

* fix ret

* additional comment in cluster

* Revert "additional comment in cluster"

This reverts commit ce69fa1.

* additional comment in cluster

* refactor StateChangeConf

* remove ResourceClusterRefreshFunc

* attribute not necessary
@lantoli
Merge branch 'master' into CLOUDP-274532_merge_redaction_log
a6efa7a 
* master: (27 commits)
  chore: Bump github.com/hashicorp/terraform-plugin-framework (#2632)
  chore: Bump tj-actions/verify-changed-files (#2629)
  chore: Bump peter-evans/create-pull-request from 7.0.3 to 7.0.5 (#2628)
  chore: Bump go.mongodb.org/atlas-sdk/v20240805004 (#2630)
  chore: Bump github.com/hashicorp/terraform-plugin-go (#2631)
  fix: Makes `mongodbatlas_alert_configuration` Datadog acceptance tests non-parallel (#2626)
  chore: Improves schema Description / MarkdownDescription (#2605)
  fix doc (#2619)
  chore: Updates CHANGELOG.md header for v1.20.0 release
  chore: Updates examples link in index.md for v1.20.0 release
  chore: Updates CHANGELOG.md for #2617
  chore: Removes 1.20 deprecations (#2617)
  chore: Updates CHANGELOG.md for #2603
  fix: Updates `integration_id` in `mongodbatlas_alert_configuration` resource to be Optional+Computed (#2603)
  chore: fixed examples broken links (#2613)
  adjust instance size of sharded cluster to M30 and above (#2615)
  doc: remove EOL sentences (#2616)
  Dialed in the version (#2614)
  chore: Updates CHANGELOG.md for #2604
  fix: Supports using decimal in cluster+adv_cluster advanced_configuration `oplog_min_retention_hours` (#2604)
  ...

# Conflicts:
#	go.mod
#	go.sum
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Oct 1, 2024
@github-actions github-actions bot closed this Oct 4, 2024
@lantoli lantoli reopened this Oct 4, 2024
@lantoli lantoli removed the stale label Oct 4, 2024
@lantoli
Merge branch 'master' into CLOUDP-274532_merge_redaction_log
7c36c2c 
* master:
  chore: Updates Atlas Go SDK (#2659)
  build(deps): bump go.mongodb.org/atlas-sdk (#2654)
  change only latest version (#2652)
  chore: Bump actions/checkout from 4.1.7 to 4.2.0 (#2649)
  chore: Bump tj-actions/verify-changed-files (#2650)
  go1.23.1 (#2648)
  chore: Updates TF to 1.9.6, Go to 1.23.1 and Go linter to 1.61.0 (#2647)
  use new projects in tests (#2643)
  chore: Updates CHANGELOG.md for #2640
  fix: Enforces `priority` descending order in `region_configs` in `mongodbatlas_advanced_cluster` (#2640)
  doc: Improves documentation for supported MongoDB versions in cluster and advanced_cluster (#2635)
  chore: Updates CHANGELOG.md for #2637
  feat: Adds `custom_zone_mapping_zone_id` to `mongodbatlas_global_cluster_config` and deprecates `custom_zone_mapping` (#2637)
  chore: Creates test group `mongodbatlas_global_cluster_config` and updates tests (#2636)
  doc: Updates `troubleshooting.md` to include `mongodbatlas_alert_configuration` issue causing non-empty plans due to `integration_id` (#2627)

# Conflicts:
#	go.mod
#	go.sum
@lantoli lantoli marked this pull request as ready for review October 4, 2024 07:47
@lantoli lantoli requested review from a team as code owners October 4, 2024 07:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

APIx bot: a message has been sent to Docs Slack channel

@lantoli
Copy link
Member Author

lantoli commented Oct 4, 2024

one test failing because out of capacity

maastha
maastha approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit 52d6f00 into master Oct 4, 2024
39 of 40 checks passed
@lantoli lantoli deleted the CLOUDP-274532_merge_redaction_log branch October 4, 2024 09:36
svc-apix-Bot added a commit that referenced this pull request Oct 4, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2634
b4d6674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @maastha