Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Supports redact_client_log_data in mongodbatlas_advanced_cluster #2600

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: Supports redact_client_log_data in mongodbatlas_advanced_cluster #2600

merged 6 commits into from
Sep 16, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Sep 16, 2024 •
edited
Loading

Description

Supports redact_client_log_data in mongodbatlas_advanced_cluster.

It's based on PR 2539 as redact_client_log_data has similar uses cases to replica_set_scaling_strategy.

Link to any related issue(s): CLOUDP-268737

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli changed the base branch from master to CLOUDP-270155-redaction-dev September 16, 2024 11:20
@lantoli lantoli marked this pull request as ready for review September 16, 2024 11:34
@lantoli lantoli requested a review from a team as a code owner September 16, 2024 11:34
oarbusi
oarbusi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lantoli lantoli requested a review from a team as a code owner September 16, 2024 14:33
@lantoli lantoli merged commit b9e69e1 into CLOUDP-270155-redaction-dev Sep 16, 2024
34 of 35 checks passed
@lantoli lantoli deleted the CLOUDP-268737_redactClientLogData branch September 16, 2024 14:38
AgustinBettati
AgustinBettati reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docs is in a follow up PR right?

@lantoli
Copy link
Member Author

lantoli commented Sep 16, 2024 •
edited
Loading

@AgustinBettati correct, I saw that I forgot doc when it was already merged, I'll add it when implementing cluster resource: #2601

lantoli added a commit that referenced this pull request Oct 4, 2024
@lantoli
chore: Merges redaction log feature to master (#2634)
52d6f00 
* feat: Supports `redact_client_log_data` in `mongodbatlas_advanced_cluster` (#2600)

* use SDK Preview

* add redact_client_log_data to schema

* plural ds

* resource

* tests

* changelog

* feat: Supports `redact_client_log_data` in `mongodbatlas_cluster` (#2601)

* doc

* changelog

* new atlas functions

* data sources

* resource

* tests

* rename CRUD functions

* wait for cluster changes

* apply feedback for changelog

* use acc.CheckRSAndDS

* fix ret

* additional comment in cluster

* Revert "additional comment in cluster"

This reverts commit ce69fa1.

* additional comment in cluster

* refactor StateChangeConf

* remove ResourceClusterRefreshFunc

* attribute not necessary

* fix update in cluster

* fix plural ds tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinBettati AgustinBettati AgustinBettati left review comments

@oarbusi oarbusi oarbusi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lantoli @AgustinBettati @oarbusi