Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes 1.20 deprecations #2617

Merged
merged 7 commits into from
Sep 20, 2024
Merged

chore: Removes 1.20 deprecations #2617

merged 7 commits into from
Sep 20, 2024

Conversation

EspenAlbert
Copy link
Collaborator

Description

Removes 1.20 deprecations

Link to any related issue(s): CLOUDP-274706

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review September 20, 2024 08:00
@EspenAlbert EspenAlbert requested review from a team as code owners September 20, 2024 08:00
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@maastha
Copy link
Collaborator

maastha commented Sep 20, 2024

There's also some deprecations in federated database instance for Sept 2024

terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance/data_source_federated_database_instance.go

Line 232 in 02281f2

"cluster_id": {

Should we remove these as well?

@EspenAlbert
Copy link
Collaborator Author

There's also some deprecations in federated database instance for Sept 2024

terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance/data_source_federated_database_instance.go

Line 232 in 02281f2

"cluster_id": {

Should we remove these as well?

I wasn't sure. Sept 2024, does it mean we remove it before or after? 😅

maastha
maastha approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lantoli
lantoli reviewed Sep 20, 2024
View reviewed changes
internal/service/federateddatabaseinstance/data_source_federated_database_instance.go
@@ -229,10 +228,6 @@ func schemaFederatedDatabaseInstanceStoresDataSource() *schema.Schema {
Type: schema.TypeString,
Computed: true,
},
"cluster_id": {
Copy link
Member

@lantoli lantoli Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from removing the attribute from the schema, have you removed logic from the CRUD operations and tests?
same for all removed attributes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was searching through and couldn't find any usage of cluster_id or clusterId

@EspenAlbert
Copy link
Collaborator Author

Bypassing docs approval to avoid blocking the release. Can do follow-up changes if necessary.
Failing tests are the same in dev but passes in QA

@EspenAlbert EspenAlbert merged commit 0544780 into master Sep 20, 2024
33 of 35 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-274706_release_deprecations branch September 20, 2024 11:09
svc-apix-Bot added a commit that referenced this pull request Sep 20, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2617
cdc90e3
carriecwk
carriecwk reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@carriecwk carriecwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lantoli added a commit that referenced this pull request Sep 25, 2024
@lantoli
Merge branch 'master' into CLOUDP-274532_merge_redaction_log
a6efa7a 
* master: (27 commits)
  chore: Bump github.com/hashicorp/terraform-plugin-framework (#2632)
  chore: Bump tj-actions/verify-changed-files (#2629)
  chore: Bump peter-evans/create-pull-request from 7.0.3 to 7.0.5 (#2628)
  chore: Bump go.mongodb.org/atlas-sdk/v20240805004 (#2630)
  chore: Bump github.com/hashicorp/terraform-plugin-go (#2631)
  fix: Makes `mongodbatlas_alert_configuration` Datadog acceptance tests non-parallel (#2626)
  chore: Improves schema Description / MarkdownDescription (#2605)
  fix doc (#2619)
  chore: Updates CHANGELOG.md header for v1.20.0 release
  chore: Updates examples link in index.md for v1.20.0 release
  chore: Updates CHANGELOG.md for #2617
  chore: Removes 1.20 deprecations (#2617)
  chore: Updates CHANGELOG.md for #2603
  fix: Updates `integration_id` in `mongodbatlas_alert_configuration` resource to be Optional+Computed (#2603)
  chore: fixed examples broken links (#2613)
  adjust instance size of sharded cluster to M30 and above (#2615)
  doc: remove EOL sentences (#2616)
  Dialed in the version (#2614)
  chore: Updates CHANGELOG.md for #2604
  fix: Supports using decimal in cluster+adv_cluster advanced_configuration `oplog_min_retention_hours` (#2604)
  ...

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carriecwk carriecwk carriecwk left review comments

@AgustinBettati AgustinBettati AgustinBettati left review comments

@maastha maastha maastha approved these changes

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EspenAlbert @maastha @lantoli @jeroenvervaeke @AgustinBettati @carriecwk