Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes import doc for mongodbatlas_mongodb_employee_access_grant #2619

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: Fixes import doc for mongodbatlas_mongodb_employee_access_grant #2619

merged 1 commit into from
Sep 20, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Sep 20, 2024 •
edited
Loading

Description

Fixes import doc for mongodbatlas_mongodb_employee_access_grant

Link to any related issue(s): CLOUDP-274735

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Sep 20, 2024
@lantoli lantoli force-pushed the CLOUDP-274735_access_grant_doc branch from d36389f to 9cd4b0a Compare September 20, 2024 12:35
@lantoli lantoli marked this pull request as ready for review September 20, 2024 12:36
@lantoli lantoli requested review from a team as code owners September 20, 2024 12:36
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@lantoli
Copy link
Member Author

lantoli commented Sep 20, 2024

no doc review needed as it's only the resource name

@lantoli lantoli merged commit 436096d into master Sep 20, 2024
40 checks passed
@lantoli lantoli deleted the CLOUDP-274735_access_grant_doc branch September 20, 2024 20:56
lantoli added a commit that referenced this pull request Sep 25, 2024
@lantoli
Merge branch 'master' into CLOUDP-274532_merge_redaction_log
a6efa7a 
* master: (27 commits)
  chore: Bump github.com/hashicorp/terraform-plugin-framework (#2632)
  chore: Bump tj-actions/verify-changed-files (#2629)
  chore: Bump peter-evans/create-pull-request from 7.0.3 to 7.0.5 (#2628)
  chore: Bump go.mongodb.org/atlas-sdk/v20240805004 (#2630)
  chore: Bump github.com/hashicorp/terraform-plugin-go (#2631)
  fix: Makes `mongodbatlas_alert_configuration` Datadog acceptance tests non-parallel (#2626)
  chore: Improves schema Description / MarkdownDescription (#2605)
  fix doc (#2619)
  chore: Updates CHANGELOG.md header for v1.20.0 release
  chore: Updates examples link in index.md for v1.20.0 release
  chore: Updates CHANGELOG.md for #2617
  chore: Removes 1.20 deprecations (#2617)
  chore: Updates CHANGELOG.md for #2603
  fix: Updates `integration_id` in `mongodbatlas_alert_configuration` resource to be Optional+Computed (#2603)
  chore: fixed examples broken links (#2613)
  adjust instance size of sharded cluster to M30 and above (#2615)
  doc: remove EOL sentences (#2616)
  Dialed in the version (#2614)
  chore: Updates CHANGELOG.md for #2604
  fix: Supports using decimal in cluster+adv_cluster advanced_configuration `oplog_min_retention_hours` (#2604)
  ...

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspenAlbert EspenAlbert EspenAlbert approved these changes

Assignees
No one assigned
Labels
bug skip-changelog-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @EspenAlbert