-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.0 #761
Merged
Merged
v1.9.0 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Side Nav Container Attributes
[Chore] Add Code Climate Config
[Chore] BEM SCSS Formatting Update
[Bug] Side Nav Width
resolve value changes issue
[Bug] OffCanvas & Modal reset defaults on close
[Chore] Update Shared Module
[Chore] WYSIWYG Documentation
Resolve document issues of go-timepicker module.
[Chore] Table Content Borders
[Bug] Table False Values
resolve ux issues
[Feature] Select Typeahead Enhancements
[Chore] Forms Enhancements
[Feature] Forms Grid
[Bug] Toaster Top
[Feature] Button Groups
[Chore] v1.9.0 Documentation Update
StevenUlmer
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log for
v1.9.0
Note:
A change was made to the
go-table
(see below under "Bug Fixes") that resolves issues around0
values in thetableData
and sorting/rendering those values. The workaround for this was to provide a template to the column and render the value through the template or return the column as a string. This workaround can now be removed and0
values should sort/render properly in the table.Please make an effort to adjust these instances where the workaround was implemented after updating to this version.
New Features
Button Group
go-button-group
) to handle instances where buttons need to be grouped together. [Feature] Button Groups #754Grid
go-container
elements to be used when building forms that modifies thego-column
elements inside of the container to have appropriate spacing for forms. (ex:/ui-kit/forms
or/standards/grid/#form-container
) [Feature] Forms Grid #752Links
go-link
to make it "unstyled" (go-link--unstyled
) [Chore] Forms Enhancements #758Select
Side Nav
Timepicker
dark
theme [Chore] Forms Enhancements #758WYSIWYG
Bug Fixes
Modal
Off Canvas
Side Nav
Select
appendTo="body"
applied were not correctly aligned resolve ux issues #740Table
false
values in a table would not render properly [Bug] Table False Values #7500
values would not render properly [Bug] Table False Values #750Toaster
Timepicker
General
GoSharedModule
[Chore] Update Shared Module #745/ui-kit/forms
) [Chore] Forms Enhancements #758go-lib
andgo-style-guide
projects to meet the scss-lint standards set [Chore] BEM SCSS Formatting Update #741go-timepicker
Design
color
property on various form elements where it was incorrect [Chore] Forms Enhancements #758go-form--dark
applied [Chore] Forms Enhancements #758