Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Forms Enhancements #758

Merged
merged 1 commit into from
Feb 18, 2021
Merged

[Chore] Forms Enhancements #758

merged 1 commit into from
Feb 18, 2021

Conversation

grahamhency
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
    Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

Resolves #757

What is the new behavior?

  • Fixes incorrect color values on go-select for light and dark themes
  • Adds support for dark theme on go-timepicker (placeholder styles)
  • Adds further support for content in forms with go-form--dark applied
  • Fixes incorrect color values on anything using go-input mixin
  • Adds modifier for "unstyled" go-links
  • Adds documentation on base /ui-kit/forms route in style guide for full suite of Goponents form elements

Does this PR introduce a breaking change?

  • Yes
  • No

@grahamhency grahamhency requested review from deotte and a team February 17, 2021 21:56
@grahamhency grahamhency added the UX Review Waiting on review from UX label Feb 17, 2021
Copy link
Contributor

@deotte deotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@grahamhency grahamhency merged commit 1668082 into dev Feb 18, 2021
@grahamhency grahamhency deleted the chore_forms_enhancements branch February 18, 2021 14:17
@grahamhency grahamhency mentioned this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Review Waiting on review from UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Form Control Input Font Color Changes
2 participants