resolve ux issues #740
resolve ux issues #740
Conversation
| .ng-dropdown-panel.ng-select-bottom { | ||
| border: 0; | ||
| } |
There was a problem hiding this comment.
I'm not sure showing the white border is the route we want to take here. It's pretty bold. I looked through the DSM to see if we have dark selects documented anywhere and I couldn't find any. I reached out to @mobi/tangoe-ux-ui to see if they can provide some insight on what we should be doing here.
There was a problem hiding this comment.
Okay. Please let me know if there are any changes required.
There was a problem hiding this comment.
@amitpatra91 I merged some SCSS changes to the select the other day and it caused merge conflicts with this branch. I went ahead and rebased with dev and fixed those conflicts for you and force pushed up the new changes.
These 3 lines actually ended up being added back, but we're still waiting to hear back from @mobi/tangoe-ux-ui on what route to take for styles here. When they get back with us we can proceed with this PR.
Alternatively, if you want to merge this as is and create an issue for the dark themed ng-select borders and handle it in a separate PR that would also work and allow us to merge these fixes with the next release. I'll leave it up to you how you want to do it.
If you make additional changes to this PR, make sure you pull down the latest changes first!
There was a problem hiding this comment.
Per Teams:
Amit:
I will create separate pull request for go-select dark theme related changes. Please release the remaining css changes. Issue #755 created to address this.
grahamhency
force-pushed
the
go-select_ux_issues
branch
from
2c161cc to
df6cb6b
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Resolves 722
What is the new behavior?
Does this PR introduce a breaking change?