Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Select Typeahead Enhancements #749

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

grahamhency
Copy link
Contributor

@grahamhency grahamhency commented Feb 15, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
    Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

  • Drop down is hidden when the select is searchable and has no items
  • Drop down arrow is hidden if the select is a typeahead and has items OR otherwise specified through the new hideDropDownArrow binding

Does this PR introduce a breaking change?

  • Yes
  • No

It shouldn't?

@grahamhency grahamhency merged commit 81103c3 into dev Feb 17, 2021
@grahamhency grahamhency deleted the feature_select_typeahead_enhancements branch February 17, 2021 22:07
@grahamhency grahamhency mentioned this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Hide dropdown arrow on go-select [Feature] Hide typeToSearchText on Go-Select
2 participants