-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Task List and filters with error handlers for Scheduler #1957
Conversation
…/nl-kat-coordination into fix-more-scheduler-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be improved. Tests are failing, and there are errors in return types. Moreover, there is a mix of type annotation styles (e.g. Optional[None]
vs ... | None
), so these should be rewritten to keep consistency.
…-more-scheduler-error-handling
…-more-scheduler-error-handling
…-more-scheduler-error-handling
…/nl-kat-coordination into fix-more-scheduler-error-handling
…-more-scheduler-error-handling
Checklist for QA:
What works:Error message is shown on the Tasks, Health checks, when opening a finding object, and on the 'See Details' page in the Katalogus. When enabling the scheduler again the error message disappears again. What doesn't work:n/a Bug or feature?:n/a |
…-more-scheduler-error-handling
…/nl-kat-coordination into fix-more-scheduler-error-handling
…-more-scheduler-error-handling
…-more-scheduler-error-handling
…-more-scheduler-error-handling
During QA the following issues were identified:
DnsRecords boefje details page in this branch:Template file removed from PR |
From QA perspective it looks good now. The pages that were not properly loading in the katalogus now work again. Can be merged after Review has approved the changes. |
One little thing I am fixing now is that the normalizer detail page is not showing the task list, but this I am fixing now, thanks! |
…vws/nl-kat-coordination into fix-more-scheduler-error-handling01~
…vws/nl-kat-coordination into fix-more-scheduler-error-handling01~
…fix-more-scheduler-error-handling01
…/nl-kat-coordination into fix-more-scheduler-error-handling
* main: (31 commits) Refactor Task List and filters with error handlers for Scheduler (#1957) Fix filtering on plugin_id for normalizers (#3226) Implement `structlog` (#3175) Gather BIT metrics [implementation] (#3122) Add observation data to observation table in OOI detail page (#3186) cve-2024-6387 from RickGeex (#3194) Recalculate bit when a config object changes (#3206) Use more concise regexes (#3181) Updated Django (#3217) Updated `zipp` (#3215) Feature/boefje normalizer config models (#3118) Updated `certifi` (#3209) Add pluginToggler.js to Aggregate Report (#3202) Update to Django 5.0 (#2939) Update Dockerfile, fix Sonarcloud issue (#3180) Better default list of world writable domains in CSP checker (#3165) Update 1.16 release notes (#3195) Remove non standard header findings and add deprecated headers findings (#3127) Fix/sonarcloud https redirect dockerfiles (#3185) Bump docker/build-push-action from 5 to 6 (#3164) ...
Changes
Task list can be found at:
"Tasks" in main menu
OOI detail page
Boefje Detail page
When scheduler client is offline, throw a ConnectionError and catch it to show message in rocky.
Add more task details for when task fetching fails/success, or (re)scheduling task fails, or get task failures. (plugin + OOI)
Issue link
#1955
Closes #1955
How's everything related?
Proof
Errors will be redirected to the health page:
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.