-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non standard header findings and add deprecated headers findings #3127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No remarks
Seeing that these headers are not longer required, they are however still not-standard. There's also the deprecated headers that might warrant a similar warning |
…s/nl-kat-coordination into remove-nonstandard-headers
Nice! looks good to me. |
As discussed with @noamblitz the title of the finding is renamed to "KAT-NONSTANDARD-HEADERS" for all these headers to include the headers listed below. In the future it would be nice to have these split into two categories: Non-standard findings and deprecated findings.
|
Checklist for QA:
What works:Looks good. Manually added the various deprecated and non-standard hosts. They are now all gathered under the'Non-standard header' finding. Created a new ticket to split these into non-standard and deprecated headers, as that would be more ideal. #3188 What doesn't work:n/a Bug or feature?:n/a |
* main: (31 commits) Refactor Task List and filters with error handlers for Scheduler (#1957) Fix filtering on plugin_id for normalizers (#3226) Implement `structlog` (#3175) Gather BIT metrics [implementation] (#3122) Add observation data to observation table in OOI detail page (#3186) cve-2024-6387 from RickGeex (#3194) Recalculate bit when a config object changes (#3206) Use more concise regexes (#3181) Updated Django (#3217) Updated `zipp` (#3215) Feature/boefje normalizer config models (#3118) Updated `certifi` (#3209) Add pluginToggler.js to Aggregate Report (#3202) Update to Django 5.0 (#2939) Update Dockerfile, fix Sonarcloud issue (#3180) Better default list of world writable domains in CSP checker (#3165) Update 1.16 release notes (#3195) Remove non standard header findings and add deprecated headers findings (#3127) Fix/sonarcloud https redirect dockerfiles (#3185) Bump docker/build-push-action from 5 to 6 (#3164) ...
Changes
Remove findings from non standard headers as stated in #2731
Issue link
Closes #2731
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.