Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile, fix Sonarcloud issue #3180

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Update Dockerfile, fix Sonarcloud issue #3180

merged 12 commits into from
Jul 8, 2024

Conversation

underdarknl
Copy link
Contributor

Changes

Adds quotes as requested / pointed out by sonarcloud.

Issue link

https://sonarcloud.io/project/issues?resolved=false&id=minvws_nl-kat-coordination&open=AY_dVhN2GgO8mB8X8BHj

QA notes

Kat should still build when running make kat.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl added boefjes Issues related to boefjes chore labels Jul 3, 2024
@underdarknl underdarknl requested a review from a team as a code owner July 3, 2024 14:17
ammar92
ammar92 reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also Dockerfiles for:

  • ./bytes/Dockerfile
  • ./rocky/Dockerfile
  • ./keiko/Dockerfile
  • ./octopoes/Dockerfile
  • ./mula/Dockerfile

Donnype
Donnype previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can trust the builds as a check 👍

@underdarknl
Copy link
Contributor Author

I think we can trust the builds as a check 👍

Yup, but somehow Keiko is failing to connect. Maybe I should have not made the port change. Keep your pr's small :P

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good, no issues when compiling and the onboarding flow still works.

What doesn't work:

n/a

Bug or feature?:

n/a

@dekkers dekkers merged commit fd23a56 into main Jul 8, 2024
38 checks passed
@dekkers dekkers deleted the fix/sonarcloud-unquoted-vars branch July 8, 2024 11:26
jpbruinsslot added a commit that referenced this pull request Jul 16, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/refactor-queue
78e0101 
* main: (31 commits)
  Refactor Task List and filters with error handlers for Scheduler  (#1957)
  Fix filtering on plugin_id for normalizers (#3226)
  Implement `structlog` (#3175)
  Gather BIT metrics [implementation] (#3122)
  Add observation data to observation table in OOI detail page (#3186)
  cve-2024-6387 from RickGeex (#3194)
  Recalculate bit when a config object changes (#3206)
  Use more concise regexes (#3181)
  Updated Django (#3217)
  Updated `zipp` (#3215)
  Feature/boefje normalizer config models (#3118)
  Updated `certifi` (#3209)
  Add pluginToggler.js to Aggregate Report (#3202)
  Update to Django 5.0 (#2939)
  Update Dockerfile, fix Sonarcloud issue (#3180)
  Better default list of world writable domains in CSP checker (#3165)
  Update 1.16 release notes (#3195)
  Remove non standard header findings and add deprecated headers findings (#3127)
  Fix/sonarcloud https redirect dockerfiles (#3185)
  Bump docker/build-push-action from 5 to 6 (#3164)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 left review comments

@dekkers dekkers dekkers approved these changes

@Donnype Donnype Donnype left review comments

Assignees
No one assigned
Labels
boefjes Issues related to boefjes chore
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@underdarknl @stephanie0x00 @dekkers @ammar92 @Donnype