-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a prompt when files modified externally on disk (apply, ignore, diff) #14298
Comments
As a clarification, simply showing a warning (and then overwriting the file?) doesn't really capture the spirit of the problem here, so the resolution needs to do more then just show a warning - it also needs to keep control over what subsequently occurs in the hands of the user, not the application, by virtue of a prompt or something. |
My original comment explains that there a user choice is required so the user can chose "reload, cancel (i.e. keep the file in the editor), close or diff". Also my original title was "Files modified externally on disk are automatically reloaded without warning". |
Related problem #19826 |
I'd call this issue very important! Problem:
--> you wont even notice, that the file has been reloaded if your not really looking at it. |
This issue has more than 1.5years open. Is the team not interested/willing to fix this? I simply can't start using VSCode as my main editor until this is addressed. |
Problem persist in last VSCode Version in WS10 Pro. We all lost work every week |
I am merging this #23107 which talks about having a setting to control if a change outside of VSCode should bring up a confirmation or not. @euginio can you please explain how this behaviour means you lost work? Others: would like to understand why it is so important to be notified when a file changed externally? What is the benefit of getting a confirmation dialog popup (probably even modal?) each time a file has changed? |
Is this closed as in "won't do"? |
@siran how is my comment in #14298 (comment) indicating that? |
@bpasero: I saw the ticket "closed" and I misuderstood. My comment was an honest question, no subtext. Answering your question: In my experience: being notified if a file changes gives me a greater sense of control/security over the files I have open, when switching branches, for example. Or when a file has been modified by another process or editor. Maybe I'm just watching a log file, and I don't want to change what Im seeing without accepting it, I find deeply disturbing that a file I have open in my editor can change silently without notice. |
As far as I know, modified files are not updated/changed silently by VS Code, so there is no 'active loss of work' since you had not modified the file. However it could certainly make you waste time, or make to resort to stupid tricks like modifying a file with a space not to have it changed silently, unadvertently and unwillingly by VSCode. |
Steps to Reproduce:
Files modified externally on disk are automatically reloaded without warning. This means that I'm not aware that they have changed. It would good to have an indication that this happened with an choice to compare & merge the new and old files, keep the old version or load the new version. I would guess that this would have to be configurable by file or file type (with a global default). For example, SlickEdit shows a prompt to allow reload, cancel (i.e. keep the file in the editor), close or diff.
The text was updated successfully, but these errors were encountered: