Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content is newer on disk should have overwrite call to action. UX issue #31063

Closed
nojvek opened this issue Jul 19, 2017 · 5 comments
Closed

Content is newer on disk should have overwrite call to action. UX issue #31063

nojvek opened this issue Jul 19, 2017 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window

Comments

@nojvek
Copy link
Contributor

nojvek commented Jul 19, 2017

I change my theme and I see this:

image

Its already on the compare screen so the CTA is meaningless.

So I click compare and I see the info box.

image

I type "ctrl+s" and go back to compare.

The appropriate call to actions are just present me with "Overwrite, undo, Cancel".

I searched help for overwrite and it doesn't even exist in edit menu.

image

My solution was to just close vscode and make the change myself after a restart. That is a terrible work around but it got the job done.

@vscodebot vscodebot bot added the workbench label Jul 19, 2017
@bpasero
Copy link
Member

bpasero commented Jul 20, 2017

@nojvek the actions for overwriting or taking the change are in the editor toolbar here:

image

We can revisit to make them more prominent somehow.

@bpasero bpasero added feature-request Request for new features or functionality ux User experience issues file-explorer Explorer widget issues labels Jul 20, 2017
@bpasero
Copy link
Member

bpasero commented Jul 20, 2017

Btw you should never get this error when changing a setting. @sandy081 is working on improving this flow a lot.

@bpasero
Copy link
Member

bpasero commented Jul 20, 2017

Related: #14298 and #20876

@bpasero bpasero removed the workbench label Nov 16, 2017
@isidorn isidorn added file-io File I/O and removed file-explorer Explorer widget issues labels Nov 17, 2017
@bpasero bpasero added workbench-editors Managing of editor widgets in workbench window and removed file-io File I/O ux User experience issues labels Nov 17, 2017
@bpasero bpasero removed their assignment Nov 17, 2017
@qqtrend
Copy link

qqtrend commented Apr 29, 2018

I thought I'd +1 this, rather than start a new issue. I sometimes get this error. In the little popup I want it to offer more than just the "Compare" button. I want a "Just Save It" button. (Or, it could be called "Overwrite Anyway".

I don't want to mess around doing diffs, and having to work out what has changed and which is the correct version. I know that the version in the editor is the code I want on disk. (In my case it is because I forgot to save before I ran tests, and they have a side-effect of automatically fixing whitespace and similar issues.)

To be clear: I do want the popup to tell me the file on disk is newer. I just want a quick way to tell it I know what I'm doing.

@bpasero
Copy link
Member

bpasero commented May 24, 2018

Merging into #46706

@bpasero bpasero closed this as completed May 24, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants