Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some sort of warning when file has changed from outside #34333

Closed
nmaxcom opened this issue Sep 13, 2017 · 1 comment
Closed

Add some sort of warning when file has changed from outside #34333

nmaxcom opened this issue Sep 13, 2017 · 1 comment
Assignees

Comments

@nmaxcom
Copy link

nmaxcom commented Sep 13, 2017

I'm aware you guys (@stringham) pulled off something very needed in this PR. Thank you for that.

Still, unless the file change is something huge, I find myself coming back to the editor after working somewhere else and going to modify an additional piece of data in that file, without realizing that the file has changed, potentially messing the 'new' file and/or unknowingly overwriting it.

There should be some warning or prompt (like in other editors) to make it clear that the data has been updated from the outside.

Now, thanks to that PR I can either go back and save somewhere else or review the new changes from the outside... I have options. But only if I know that file has been reloaded. As it is now is very sneaky and error prone IMHO.

@bpasero
Copy link
Member

bpasero commented Sep 14, 2017

#14298
#20876

@bpasero bpasero closed this as completed Sep 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants