Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to file on disk MUST NOT be loaded without user confirmation #45420

Closed
hgroene opened this issue Mar 9, 2018 · 5 comments
Closed

Changes to file on disk MUST NOT be loaded without user confirmation #45420

hgroene opened this issue Mar 9, 2018 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-io File I/O info-needed Issue requires more information from poster

Comments

@hgroene
Copy link

hgroene commented Mar 9, 2018

  • VSCode Version: 1.20.1
  • OS Version: Ubuntu 16.04

Steps to Reproduce:

  1. Outside VSCode, copy file A to file B
  2. Open file B in VSCode, make changes and save (do not close file B buffer)
  3. Change view to not file B buffer.
  4. [Accidentally] repeat step 1
  5. Change view back to file B buffer.
  6. See how all your changes in buffer B are destroyed when VSCode silently reloads file B
  7. Cry over all the work you just lost. :-(

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 9, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero
Copy link
Member

bpasero commented Mar 9, 2018

@hgroene to be clear, you saved a file in VS Code and then you overwrote the contents with a copy operation outside of VS Code and then you say you lost your changes? But you intentionally overwrote the file outside VS Code, no?

@bpasero bpasero added the info-needed Issue requires more information from poster label Mar 9, 2018
@hgroene
Copy link
Author

hgroene commented Mar 9, 2018

I saved a file in VSCode and then unintentionally overwrote the file outside of VSCode. The file was still open in VSCode but the contents were replaced with the changed file.

@bpasero bpasero added the file-io File I/O label Mar 9, 2018
@bpasero
Copy link
Member

bpasero commented Mar 9, 2018

/duplicate #14298

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 9, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 9, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-io File I/O info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants