Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Default Shell shows up in yarn web #118978

Closed
Tyriar opened this issue Mar 15, 2021 · 2 comments
Closed

Select Default Shell shows up in yarn web #118978

Tyriar opened this issue Mar 15, 2021 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded web Issues related to running VSCode in the web
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2021

Running it gives this error which is expected, we should not show the command when no process support exists.

ERR NotSupported: Error: NotSupported
	at WorkerExtHostTerminalService.$getAvailableShells (http://localhost:8081/static/out/vs/workbench/api/common/extHostTerminalService.js:624:19)
	at RPCProtocol._doInvokeHandler (http://localhost:8081/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:348:27)
	at RPCProtocol._invokeHandler (http://localhost:8081/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:333:45)
	at RPCProtocol._receiveRequest (http://localhost:8081/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:260:32)
	at RPCProtocol._receiveOneMessage (http://localhost:8081/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:188:26)
	at http://localhost:8081/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:69:52
	at Emitter.fire (http://localhost:8081/static/out/vs/base/common/event.js:479:38)
	at MessagePort.ExtensionWorker.channel.port1.onmessage (http://localhost:8081/static/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:76:25)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label web Issues related to running VSCode in the web labels Mar 15, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 15, 2021
@Tyriar Tyriar self-assigned this Mar 15, 2021
@Tyriar Tyriar closed this as completed in 094274f Mar 15, 2021
@Tyriar Tyriar mentioned this issue Mar 15, 2021
Closed
lramos15 pushed a commit that referenced this issue Mar 16, 2021
@Tyriar @lramos15
Don't show select default shell when proc support not registered
d5c24fe 
Fixes #118978
lramos15 pushed a commit that referenced this issue Mar 18, 2021
@Tyriar @lramos15
Don't show select default shell when proc support not registered
2ce4bf6 
Fixes #118978

explorerModel: add toString to explorerItem for more precise error message

multicursor aria polish

fixes #118964
fixes #118965

debt - consolidate process usage

:lipstick: process use

fix #118970

accessibility: 1000 page size as default

Do no install repo on Raspberry Pi OS (#118826)

* Do no install repo on Raspberry Pi OS

* 💄

Co-authored-by: João Moreno <[email protected]>

firefox: do not use ctrl+shift+P for show all commands since it is taken, make sure F1 is rendered

untitledHint: introduce default for workbench.editor.untitled.hint

better aria label for the remote host status bar item

fixes #118839

Fix #118958

Fix #118953

Remove unused

Remove only

Rename setting gettingStarted.hiddenCategories => workbench.welcomePage.hiddenCategories
Fixes #118990

Don't create markdown previews if cell is in edit mode

unHidePreview should also update dimensions

update seti theme. fixes #118912

test view/model range convertion with hidden cells.

share drag impl for builtin and custom md renderer.

adopt multi select in drag and drop. drag the focus or selection around the focus.

update list item height on markdown cell ctor as we might already warm up the viewport.

Fix border overlap in quick pick UI (#119039)

Fixes #107737

debt - some more process and platform 💄

debt - use product quality instead of probing for name

Adds RemoteHub to api allow list

fix build

mark APIs as deprecated

fix: typo

custom editors - make conflict resolution actions appear (#118949)

Workspace trust changes (#119017)

* Add dialog button customisation and reject promise if cancelled
* Use different promises to modal/soft requests

new debug setting for clearing a terminal before reusing; fixes #116699

Pick up fix for #117054

Update types

Ports: service -> application, defaults ->unconfigured

ignore file events while saving, more logging, #118992

more deprecations

Fix task start firing with invalid process ID in dependsOn task

This was caused by the env var relaunch @debounce decorator that was added to
prevent the process from relaunching multiple times when multiple extensions
contribute to the environment. This caused the reuseTerminal call to not have
the new processReady promise ready immediately after reuseTerminal was called.
The fix which seems safe it to just move the @debounce over to relaunchTerminal
that tasks doesn't use.

Fixes #118256

Fixes #119011: Wait for the vscode API to become available before launching extension tests
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2021
@rzhao271
Copy link
Contributor

The option still seems to show up for me when I ran yarn web on the latest distro.

proof

@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Mar 24, 2021
@rzhao271 rzhao271 reopened this Mar 24, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 24, 2021

Ah, the fix got eaten by a merge conflict

@Tyriar Tyriar closed this as completed in ab317a2 Mar 24, 2021
@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed verified Verification succeeded labels Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
3 participants
@Tyriar @rzhao271 and others