Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pseudo terminal on Web #116022

Closed
bummoblizard opened this issue Feb 7, 2021 · 9 comments · Fixed by #119024
Closed

Support for pseudo terminal on Web #116022

bummoblizard opened this issue Feb 7, 2021 · 9 comments · Fixed by #119024
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label web Issues related to running VSCode in the web
Milestone

Comments

@bummoblizard
Copy link

  1. Create a pseudo terminal in a web extension
const writeEmitter = new vscode.EventEmitter<string>();
const pty: vscode.Pseudoterminal = {
  onDidWrite: writeEmitter.event,
  open: () => writeEmitter.fire('\x1b[31mHello world\x1b[0m'),
  close: () => {}
};
vscode.window.createTerminal({ name: 'My terminal', pty });
  1. yarn web
  2. Error: Could not create terminal when process support is not registered

From my understanding, terminal is disabled on web due to the lack of process support. Should this affect the use of pseudo terminal as well? In my use case, I would like to create a fake terminal in my web extension.

@Tyriar
Copy link
Member

Tyriar commented Feb 8, 2021

The Pseudoterminal API will work when actually running in web like Codespaces, just not when running yarn web as it's a stripped down version of the server.

@Tyriar Tyriar closed this as completed Feb 8, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Feb 8, 2021
@Tyriar Tyriar reopened this Feb 9, 2021
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label web Issues related to running VSCode in the web and removed *as-designed Described behavior is as designed labels Feb 9, 2021
@Tyriar Tyriar added this to the Backlog milestone Feb 9, 2021
@Tyriar
Copy link
Member

Tyriar commented Feb 9, 2021

Reopening as live share web would like this

@setaskin
Copy link

setaskin commented Mar 9, 2021

Hi, @Tyriar , is it scheduled to be fixed soon :) ?

@Tyriar Tyriar modified the milestones: Backlog, March 2021 Mar 11, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 11, 2021

We'll try squeeze this into the iteration for next week

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2021

Fixed showing the select default shell command which doesn't work without an ext host while working on this: #118978

@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2021

@setaskin this should land in tomorrow's insiders build, if you could test whether this works for you sometime this week (ideally) that would be great!

@setaskin
Copy link

@Tyriar that is awesome!, I will test as first thing tomorrow. Thank you very much

@setaskin
Copy link

@Tyriar , I just tested with insiders. They are working great. Thanks again.

@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2021

Good to hear 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@Tyriar @setaskin @bummoblizard and others