Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boarder overlap in setting sync 'select service' UI #107737

Closed
mjbvz opened this issue Sep 29, 2020 · 6 comments · Fixed by #119039
Closed

Boarder overlap in setting sync 'select service' UI #107737

mjbvz opened this issue Sep 29, 2020 · 6 comments · Fixed by #119039
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 29, 2020

Issue Type: Bug

Repro

  1. Using the standard dark+ theme
  2. Trigger the 'select service' UI for setting sync

bug
This input has a blue boarder around it, however the two input options cut off this boarder on the sides:

Screen Shot 2020-09-29 at 12 01 53 PM

VS Code version: Code - Insiders 1.50.0-insider (0580328, 2020-09-29T09:05:00.729Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.76GB free)
Process Argv -psn_0_57833252 --crash-reporter-id cc7f0c9b-aa2b-4a45-8baa-81ffda32679e
Screen Reader no
VM 11%
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue settings-sync labels Nov 4, 2020
@rzhao271 rzhao271 added this to the Backlog milestone Nov 4, 2020
@Tyriar Tyriar assigned sandy081 and unassigned Tyriar Nov 4, 2020
@sandy081 sandy081 assigned chrmarti and unassigned sandy081 Nov 5, 2020
@sandy081 sandy081 added quick-pick Quick-pick widget issues and removed settings-sync labels Nov 5, 2020
@chrmarti chrmarti removed the polish Cleanup and polish issue label Nov 5, 2020
@chrmarti chrmarti removed this from the Backlog milestone Nov 5, 2020
@chrmarti
Copy link
Collaborator

chrmarti commented Nov 5, 2020

How do I trigger this UI?

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Nov 5, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 8, 2020

  • Stop Settings Sync if it is On.
  • Turn on Settings Sync and you will see this UI in the turn on flow.

This is available only in insiders

@chrmarti chrmarti removed the info-needed Issue requires more information from poster label Nov 9, 2020
@chrmarti chrmarti added this to the November 2020 milestone Nov 9, 2020
@Avivhdr
Copy link

Avivhdr commented Dec 12, 2020

I can't trigger it.
When I'm turning on setting sync, I get the 'select an account to sign in' UI, and not the 'select service'.

I need to set it to 'stable' so I could sync my settings.
Can it be done in another way?

image

@chrmarti chrmarti modified the milestones: January 2021, February 2021 Jan 27, 2021
@chrmarti chrmarti modified the milestones: February 2021, March 2021 Feb 19, 2021
@TylerLeonhardt
Copy link
Member

it looks like the UI for this has changed now so I'm going to close this

@TylerLeonhardt
Copy link
Member

Actually, I was able to repro after signing in and clicking on the quick pick

@TylerLeonhardt TylerLeonhardt self-assigned this Mar 15, 2021
@TylerLeonhardt
Copy link
Member

test steps:

  • turn off settings sync if it's on
  • turn on settings sync
  • you may need to log in to settings first
  • click on the title of the quick pick

You should see the blue border around the entire quick pick
image

@TylerLeonhardt TylerLeonhardt added the verification-needed Verification of issue is requested label Mar 22, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@Tyriar @TylerLeonhardt @rzhao271 @chrmarti @sandy081 @mjbvz @Avivhdr and others