Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My screen reader does not find information about a remote connection in the status bar #118839

Closed
jvesouza opened this issue Mar 12, 2021 · 8 comments
Closed

My screen reader does not find information about a remote connection in the status bar #118839

jvesouza opened this issue Mar 12, 2021 · 8 comments
Assignees
@isidorn @aeschli
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Milestone
March 2021

Comments

@jvesouza
Copy link

Issue Type: Bug
CC: @isidorn

  1. Open VSCode and activate the orca screen reader.
  2. Create and activate a remote connection.
  3. Move the focus to the status bar by pressing the f6 key a few times.
  4. Explore the status bar using the arrows.

None of the information read by the orca identifies the remote connection.

VS Code version: Code - Insiders 1.55.0-insider (06b5454, 2021-03-12T05:14:36.439Z)
OS version: Linux x64 5.11.4-arch1-1
Remote OS version: Linux x64 5.4.0-1039-azure

System Info
Item Value
CPUs Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2700)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 7.68GB (0.30GB free)
Process Argv -n --no-sandbox --crash-reporter-id bcecf5e0-97d1-4830-b28c-0943c4adab1c
Screen Reader yes
VM 0%
DESKTOP_SESSION gnome-xorg
XDG_CURRENT_DESKTOP GNOME
XDG_SESSION_DESKTOP gnome-xorg
XDG_SESSION_TYPE x11
Item Value
Remote SSH: node1.prakna.com
OS Linux x64 5.4.0-1039-azure
CPUs Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz (2 x 2593)
Memory (System) 7.78GB (3.84GB free)
VM 0%
@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021

@jvesouza I just tried this out and the Screen Reader reads "Remote Host" properly for me. Which is the aria-label which we set on the status bar remote item.
Are you saying that even the "Remote Host" part is not read for you? Or would you like something more specific? Since "Remote Host" might not be the best label

Also assigning to @aeschli since he owns the remote status bar

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach labels Mar 15, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021 •
edited
Loading

I also get "Remote Host" if I am not connected to the remote.
@aeschli I think we should update the aria label of this status bar item based on the remote connection. Do we currently do this?

Oh I see that we simply always set "Remote Host" here
Is it possible to make this more dynamic based on connection?

@jvesouza
Copy link
Author

jvesouza commented Mar 15, 2021 •
edited by isidorn
Loading

@jvesouza I just tried this out and the Screen Reader reads "Remote Host" properly for me. Which is the aria-label which we set on the status bar remote item.
Are you saying that even the "Remote Host" part is not read for you? Or would you like something more specific? Since "Remote Host" might not be the best label

The remote label is read correctly, but I'd like if possible, an identification about the remote connection.

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021

@jvesouza makes perfect sense, thanks for feedback.
This would be tackled if we use a more dynamic aria label for the remote status bar item
@aeschli can help here. Let me know if you are busy and I can also look into it. Thanks!

@isidorn isidorn removed the under-discussion Issue is under discussion for relevance, priority, approach label Mar 15, 2021
@aeschli
Copy link
Contributor

aeschli commented Mar 15, 2021

@isidorn That would be fantastic if you can just go ahead and improve the remote indicator. I don't have that much experience with good aria labels.

@isidorn isidorn added this to the March 2021 milestone Mar 15, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021

For the aria label I just went with the text that we use for the status bar, since I think it is fitting just fine. I am just stripping codicon special characters $(.

@jvesouza try it out from tomorrow with vscode insiders and let me know how it goes. Thanks

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 15, 2021
@jvesouza
Copy link
Author

Tested and approved! It was excellent.
It is now possible to easily identify the current connection, which is of great value especially if we are connected to more than one remote host.

@isidorn
Copy link
Contributor

isidorn commented Mar 16, 2021

@jvesouza lovely, thanks a lot for letting us know! Adding verified label based on your feedback.

@isidorn isidorn added the verified Verification succeeded label Mar 16, 2021
lramos15 pushed a commit that referenced this issue Mar 16, 2021
@isidorn @lramos15
better aria label for the remote host status bar item
a4d200f 
fixes #118839
lramos15 pushed a commit that referenced this issue Mar 18, 2021
@Tyriar @lramos15
Don't show select default shell when proc support not registered
2ce4bf6 
Fixes #118978

explorerModel: add toString to explorerItem for more precise error message

multicursor aria polish

fixes #118964
fixes #118965

debt - consolidate process usage

:lipstick: process use

fix #118970

accessibility: 1000 page size as default

Do no install repo on Raspberry Pi OS (#118826)

* Do no install repo on Raspberry Pi OS

* 💄

Co-authored-by: João Moreno <[email protected]>

firefox: do not use ctrl+shift+P for show all commands since it is taken, make sure F1 is rendered

untitledHint: introduce default for workbench.editor.untitled.hint

better aria label for the remote host status bar item

fixes #118839

Fix #118958

Fix #118953

Remove unused

Remove only

Rename setting gettingStarted.hiddenCategories => workbench.welcomePage.hiddenCategories
Fixes #118990

Don't create markdown previews if cell is in edit mode

unHidePreview should also update dimensions

update seti theme. fixes #118912

test view/model range convertion with hidden cells.

share drag impl for builtin and custom md renderer.

adopt multi select in drag and drop. drag the focus or selection around the focus.

update list item height on markdown cell ctor as we might already warm up the viewport.

Fix border overlap in quick pick UI (#119039)

Fixes #107737

debt - some more process and platform 💄

debt - use product quality instead of probing for name

Adds RemoteHub to api allow list

fix build

mark APIs as deprecated

fix: typo

custom editors - make conflict resolution actions appear (#118949)

Workspace trust changes (#119017)

* Add dialog button customisation and reject promise if cancelled
* Use different promises to modal/soft requests

new debug setting for clearing a terminal before reusing; fixes #116699

Pick up fix for #117054

Update types

Ports: service -> application, defaults ->unconfigured

ignore file events while saving, more logging, #118992

more deprecations

Fix task start firing with invalid process ID in dependsOn task

This was caused by the env var relaunch @debounce decorator that was added to
prevent the process from relaunching multiple times when multiple extensions
contribute to the environment. This caused the reuseTerminal call to not have
the new processReady promise ready immediately after reuseTerminal was called.
The fix which seems safe it to just move the @debounce over to relaunchTerminal
that tasks doesn't use.

Fixes #118256

Fixes #119011: Wait for the vscode API to become available before launching extension tests
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@aeschli aeschli

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
4 participants
@isidorn @jvesouza @aeschli and others