Skip to content

Commit

Permalink
Comment out a few error logs for now
Browse files Browse the repository at this point in the history
These functions  likely should never be called in these cases, but they do not seem to cause any issues
  • Loading branch information
mjbvz committed Mar 12, 2021
1 parent 498449f commit 06b5454
Showing 1 changed file with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ export interface ICreateMarkdownMessage {
id: string;
handle: number;
content: string;
contentVersion: number;
top: number;
}
export interface IRemoveMarkdownMessage {
Expand All @@ -260,8 +259,7 @@ export interface IShowMarkdownMessage {
type: 'showMarkdownPreview',
id: string;
handle: number;
content: string;
contentVersion: number;
content: string | undefined;
top: number;
}

Expand Down Expand Up @@ -1127,7 +1125,8 @@ var requirejs = (function() {

const entry = this.markdownPreviewMapping.get(cellId);
if (!entry) {
console.error('Try to hide a preview that does not exist');
// TODO: this currently seems expected on first load
// console.error(`Try to hide a preview that does not exist: ${cellId}`);
return;
}

Expand All @@ -1147,7 +1146,7 @@ var requirejs = (function() {

const entry = this.markdownPreviewMapping.get(cellId);
if (!entry) {
console.error('Try to unhide a preview that does not exist');
console.error(`Try to unhide a preview that does not exist: ${cellId}`);
return;
}

Expand All @@ -1166,7 +1165,7 @@ var requirejs = (function() {
}

if (!this.markdownPreviewMapping.has(cellId)) {
console.error('Try to delete a preview that does not exist');
console.error(`Try to delete a preview that does not exist: ${cellId}`);
return;
}

Expand All @@ -1184,7 +1183,8 @@ var requirejs = (function() {
}

if (!this.markdownPreviewMapping.has(cellId)) {
console.error('Try to update selection state for preview that does not exist');
// TODO: this currently seems expected on first load
// console.error(`Try to update selection state for preview that does not exist: ${cellId}`);
return;
}

Expand Down

0 comments on commit 06b5454

Please sign in to comment.