-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VHR10 datamodule #1082
Add VHR10 datamodule #1082
Conversation
@ashnair1 I can do this if you're busy |
Appreciate it. Might be a while before I can get back to this. |
Same :) |
f27892d
to
e5c476d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still a WIP but wanted to give intermediate feedback before you spend too long going in one direction.
e5c476d
to
377c699
Compare
409f1cb
to
773be05
Compare
773be05
to
24346a9
Compare
24346a9
to
4088b44
Compare
Let me know if/when you want me to re-review. Otherwise I'll wait until the tests pass. For the box format stuff, feel free to change things to match Kornia's expected format. Also see #985 for what I would like things to look like in the long-term. |
4088b44
to
4147430
Compare
c5e70cd
to
ee0df8a
Compare
d83be5e
to
9263b52
Compare
9263b52
to
309ec96
Compare
14acc85
to
1f74d9b
Compare
RtD CI will be fixed by #1827 Coverage drop is due to buggy codecov, rerunning minimum tests should fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are ways that this could be improved, but not without modifying kornia itself. I actually do want to do that someday, but we may also drop kornia entirely someday and switch back to torchvision-style transforms, so I'm not trying to rock the boat. This adds a much-needed VHR-10 data module, and the parts I'm uncertain about aren't public anyway, so I say we merge this and improve transform compatibility and sample consistency in the distant future.
No description provided.