Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VHR10 datamodule #1082
Add VHR10 datamodule #1082
Changes from all commits
3c3a306
41cf32d
1efc331
74c4bd5
b4511ea
f273f03
f4a96a8
fec3449
738d996
97bb234
54a3116
5bdb57a
bb4fd46
f31c82f
bf69bac
4cd4568
9d48f1f
2bdbf0f
3efa9be
e3417e8
d4700cc
756143f
f750cf4
b8f0166
0f13514
d976e5f
77d3feb
9f21d06
61a1d46
7e88d02
30b02d6
1f74d9b
1961950
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead use
torchgeo.datasets.unbind_samples
and add one extra line to modify labels?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unbind_samples
is used to convert dict of lists into list of dicts. Here we're doing the opposite.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then what about concat/merge_samples? Those do the opposite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
stack_samples
? I think concat and merge samples were forGeoDatasets
.Either way, those functions can't be used since it assumes the samples can be stacked/concatenated. This is not the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both GeoDatasets and NonGeoDatasets use the same
sample
dict format, so all collation functions are appropriate for both. Although these tend to be more used with GeoDatasets because the output also contains CRS and BoundingBox, which the default collation functions from PyTorch don't support.I see now that your output dict has lists of Tensors instead of Tensors, which is indeed different than all other builtin collation functions. I guess this is required because each sample may have a different number of objects. Not sure how people normally handle collation for that case in PyTorch.