-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VHR10DataModule #798
Add VHR10DataModule #798
Conversation
This looks great. A few suggestions to make it even better:
A sample plot from VHR10 with what I'm looking for (prediction, not ground truth): Probably better to have the label/confidence above the box instead of inside, but close enough. This was created using the following notebook, mostly using code from torchvision: Fun fact: VHR10 was actually the first dataset I added to TorchGeo. |
Regarding point 1, by passing |
That being said, I get where you're coming from. Plots from pycocotools are not as visually impressive, customizable or as informative as the second plot. I've written out a new plot function that does this. Still ironing out some details but here is a sample. (Recommend opening the image in another window for better clarity). Left (Masks and Boxes) |
@ashnair1 maybe try throwing in a |
This PR will be split into smaller PRs once I make sure everything works as expected. |
Note that the datamodule will need to be refactored once #992 is merged. But that should hopefully make it significantly simpler. |
Since this is a
CocoDataset
it might be better to subclass from torchvision's CocoDataset instead ofNonGeoDataset
. Thoughts?Plot sample (split="positive"):
Had to bump minimum version of
pyococotools
to2.0.1
to supportdraw_bbox
arg.