Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix plot methods to Datasets #253

Closed
19 tasks done
calebrob6 opened this issue Nov 19, 2021 · 6 comments · Fixed by #820
Closed
19 tasks done

Add/fix plot methods to Datasets #253

calebrob6 opened this issue Nov 19, 2021 · 6 comments · Fixed by #820
Labels
datasets Geospatial or benchmark datasets
Milestone

Comments

@calebrob6
Copy link
Member

calebrob6 commented Nov 19, 2021

The following benchmark datasets need plot(...) methods:

Further, the plot(...) methods of RasterDataset and VectorDataset need to be removed, and added individually to:

The ChesapeakeCVPR dataset is a bit of an outlier as it is a GeoDataset. I need to think more about that.

@adamjstewart
Copy link
Collaborator

Further, the plot(...) methods of RasterDataset and VectorDataset need to be reworked or removed.

I would like to move those plot methods from RasterDataset/VectorDataset to the individual dataset classes since there is so much diversity. When that happens, we'll need to change them to accept a sample instead of an image.

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Nov 19, 2021
@ashnair1
Copy link
Collaborator

@calebrob6 I've added the plot method to the SpaceNet baseclass so all currently implemented SpaceNet datasets (1,2,4,7) can be plotted.

@adamjstewart
Copy link
Collaborator

How should we handle plotting for IntersectionDataset/UnionDataset?

@calebrob6
Copy link
Member Author

How should we handle plotting for IntersectionDataset/UnionDataset?

If you aren't doing anything too crazy, you should be able to send the samples that you get from the joined dataset to the individual dataset.plot(...) methods. For example, with the Landsat8 & CDL dataset, you will be able to call both the Landast8 and CDL plot methods with the resulting samples. You could get crazy and make an IntersectionDataset.plot(...) that calls each sub-datasets's plot method and stitches together the resulting plt.Figures into some Frankenstein monster.

@adamjstewart
Copy link
Collaborator

@calebrob6 ChesapeakeCVPR is the only remaining dataset without a plot method if you want to take a stab at this.

Our point datasets (GBIF, iNaturalist, EDDMapS) also don't have plot methods. Not sure if we want to bother with them or not. If we did, I would probably want to use cartopy to make the plots more interesting.

@adamjstewart
Copy link
Collaborator

Technically not done yet, we're still waiting on VHR-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants