mypy: even more strict #2241
Merged
mypy: even more strict #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
commented
Aug 21, 2024
| [tool.mypy] | ||
| python_version = "3.10" |
There was a problem hiding this comment.
This isn't particularly useful, what we really need is python/mypy#12286
adamjstewart
commented
Aug 21, 2024
| @@ -473,7 +477,7 @@ def merge_samples(samples: Iterable[dict[Any, Any]]) -> dict[Any, Any]: | |||
| return collated | |||
|
|
|||
|
|
|||
| def unbind_samples(sample: dict[Any, Sequence[Any]]) -> list[dict[Any, Any]]: | |||
| def unbind_samples(sample: MutableMapping[Any, Any]) -> list[dict[Any, Any]]: | |||
There was a problem hiding this comment.
This should not be a sequence, this was a bug
adamjstewart
commented
Aug 21, 2024
| @@ -99,7 +99,7 @@ def forward(self, batch: dict[str, Tensor]) -> dict[str, Tensor]: | |||
|
|
|||
| # Convert boxes to default [N, 4] | |||
| if 'boxes' in batch: | |||
| batch['boxes'] = Boxes(batch['boxes']).to_tensor(mode='xyxy') # type:ignore[assignment] | |||
| batch['boxes'] = Boxes(batch['boxes']).to_tensor(mode='xyxy') | |||
There was a problem hiding this comment.
This bug was introduced in #1082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional checks like
warn_unreachablethat revealed new bugs. And fixes those bugs!I also played around with generics like:
but ran into too many issues and gave up. Maybe another day.