Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split button/primary hc fix #25066

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Split button/primary hc fix #25066

merged 2 commits into from
Oct 4, 2022

Conversation

sopranopillow
Copy link
Contributor

Current Behavior

rest:
image

hover:
image

New Behavior

rest:
image

hover:
image

Related Issue(s)

Fixes ADO 15500

@sopranopillow sopranopillow added Fluent UI react (v8) Issues about @fluentui/react (v8) Component: SplitButton labels Oct 3, 2022
@sopranopillow sopranopillow self-assigned this Oct 3, 2022
@sopranopillow sopranopillow requested review from a team and khmakoto as code owners October 3, 2022 23:16
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 765c6dd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 3, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Button 184.146 kB 184.142 kB BelowBaseline     -4 bytes
office-ui-fabric-react fluentui-react-TeachingBubble 193.034 kB 193.03 kB BelowBaseline     -4 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 97e3ebb627a8a24f805454fa0220f7e2827d3107 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 97e3ebb627a8a24f805454fa0220f7e2827d3107

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1213 1201 5000
Breadcrumb mount 2774 2792 1000
Checkbox mount 2638 2672 5000
CheckboxBase mount 2362 2380 5000
ChoiceGroup mount 4248 4281 5000
ComboBox mount 1169 1177 1000
CommandBar mount 9192 9184 1000
ContextualMenu mount 10121 10059 1000
DefaultButton mount 1352 1368 5000
DetailsRow mount 3450 3380 5000
DetailsRowFast mount 3404 3373 5000
DetailsRowNoStyles mount 3262 3261 5000
Dialog mount 2982 2959 1000
DocumentCardTitle mount 578 578 1000
Dropdown mount 3157 3139 5000
FocusTrapZone mount 1999 1940 5000
FocusZone mount 1916 1924 5000
GroupedList mount 48234 54245 2
GroupedList virtual-rerender 23154 23065 2
GroupedList virtual-rerender-with-unmount 81959 81432 2
GroupedListV2 mount 556 554 2
GroupedListV2 virtual-rerender 544 524 2
GroupedListV2 virtual-rerender-with-unmount 548 549 2
IconButton mount 1782 1794 5000
Label mount 753 753 5000
Layer mount 4195 4133 5000
Link mount 853 850 5000
MenuButton mount 1620 1608 5000
MessageBar mount 2340 2397 5000
Nav mount 3104 3132 1000
OverflowSet mount 1417 1424 5000
Panel mount 2509 2567 1000
Persona mount 1217 1264 1000
Pivot mount 1528 1524 1000
PrimaryButton mount 1495 1506 5000
Rating mount 7013 7003 5000
SearchBox mount 1497 1502 5000
Shimmer mount 2919 2934 5000
Slider mount 2102 2111 5000
SpinButton mount 4331 4282 5000
Spinner mount 814 836 5000
SplitButton mount 2848 2878 5000
Stack mount 899 900 5000
StackWithIntrinsicChildren mount 2234 2248 5000
StackWithTextChildren mount 4895 4898 5000
SwatchColorPicker mount 9565 9537 5000
TagPicker mount 2350 2368 5000
TeachingBubble mount 74347 73581 5000
Text mount 826 819 5000
TextField mount 1584 1542 5000
ThemeProvider mount 1436 1442 5000
ThemeProvider virtual-rerender 1140 1135 5000
ThemeProvider virtual-rerender-with-unmount 2009 2022 5000
Toggle mount 1130 1134 5000
buttonNative mount 544 538 5000

@sopranopillow sopranopillow merged commit 7e45524 into microsoft:master Oct 4, 2022
@sopranopillow sopranopillow deleted the split-button/primary-hc-fix branch October 4, 2022 17:44
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 5, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
3e5d385 
* master: (62 commits)
  chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458)
  chore(react-dialog): updates stories (microsoft#25070)
  refactor Progress to remove label and description slots (microsoft#25067)
  fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059)
  chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007)
  (docs): update Icon docs with examples (microsoft#24768)
  Split button/primary hc fix (microsoft#25066)
  chore(react-utilities): restricts trigger API types (microsoft#25044)
  Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
  chore: migrate whole repo to webpack 5 (microsoft#24542)
  applying package updates
  BREAKING: refactor `useTable` to be composable (microsoft#24947)
  Added shims to shim packages (microsoft#25048)
  Add Progress SPEC (microsoft#24418)
  applying package updates
  chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055)
  fix(Button): Remove margin added to buttons by Safari (microsoft#25052)
  fix: Menu triggers no longer take focus when they are mounted (microsoft#25016)
  chore: deletes react-trigger package (microsoft#25042)
  Fixed a minor typo: immmediately => immediately (microsoft#25036)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@sopranopillow @NotWoods
Split button/primary hc fix (microsoft#25066)
6dc23aa 
* removing background from menu button in Primary SplitButton

* change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

Assignees

@sopranopillow sopranopillow

Labels
Component: Button Component: SplitButton Fluent UI react (v8) Issues about @fluentui/react (v8)
Projects
None yet
Milestone
October Project Cycle Q4 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@sopranopillow @fabricteam @khmakoto @msft-fluent-ui-bot