fix(Button): Remove margin added to buttons by Safari #25052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Component: Button
Fluent UI react (v8)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47a385c:
|
Asset size changes
Baseline commit: b0b7f99bbbb05b0bd136432983a74fea252c7163 (build) |
📊 Bundle size report🤖 This report was generated against b0b7f99bbbb05b0bd136432983a74fea252c7163 |
khmakoto
approved these changes
Oct 3, 2022
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1561 | 1509 | 5000 | |
| Breadcrumb | mount | 3669 | 3765 | 1000 | |
| Checkbox | mount | 3398 | 3400 | 5000 | |
| CheckboxBase | mount | 3054 | 3041 | 5000 | |
| ChoiceGroup | mount | 5736 | 5769 | 5000 | |
| ComboBox | mount | 1581 | 1586 | 1000 | |
| CommandBar | mount | 12043 | 11965 | 1000 | |
| ContextualMenu | mount | 13532 | 13902 | 1000 | |
| DefaultButton | mount | 1762 | 1798 | 5000 | |
| DetailsRow | mount | 4687 | 4674 | 5000 | |
| DetailsRowFast | mount | 4634 | 4605 | 5000 | |
| DetailsRowNoStyles | mount | 4508 | 4492 | 5000 | |
| Dialog | mount | 3971 | 3968 | 1000 | |
| DocumentCardTitle | mount | 751 | 718 | 1000 | |
| Dropdown | mount | 4299 | 4196 | 5000 | |
| FocusTrapZone | mount | 2573 | 2585 | 5000 | |
| FocusZone | mount | 2435 | 2446 | 5000 | |
| GroupedList | mount | 67831 | 78000 | 2 | |
| GroupedList | virtual-rerender | 32225 | 32940 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 112892 | 114199 | 2 | |
| GroupedListV2 | mount | 723 | 705 | 2 | |
| GroupedListV2 | virtual-rerender | 694 | 675 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 689 | 726 | 2 | |
| IconButton | mount | 2501 | 2500 | 5000 | |
| Label | mount | 922 | 924 | 5000 | |
| Layer | mount | 5463 | 5429 | 5000 | |
| Link | mount | 1028 | 1033 | 5000 | |
| MenuButton | mount | 2182 | 2182 | 5000 | |
| MessageBar | mount | 2910 | 2923 | 5000 | |
| Nav | mount | 4307 | 4190 | 1000 | |
| OverflowSet | mount | 1768 | 1737 | 5000 | |
| Panel | mount | 3257 | 3273 | 1000 | |
| Persona | mount | 1651 | 1660 | 1000 | |
| Pivot | mount | 2105 | 2156 | 1000 | |
| PrimaryButton | mount | 1949 | 1986 | 5000 | |
| Rating | mount | 9285 | 9342 | 5000 | |
| SearchBox | mount | 2052 | 1990 | 5000 | |
| Shimmer | mount | 3796 | 3711 | 5000 | |
| Slider | mount | 2697 | 2719 | 5000 | |
| SpinButton | mount | 6010 | 6062 | 5000 | |
| Spinner | mount | 988 | 969 | 5000 | |
| SplitButton | mount | 4052 | 4002 | 5000 | |
| Stack | mount | 1155 | 1120 | 5000 | |
| StackWithIntrinsicChildren | mount | 3235 | 3223 | 5000 | |
| StackWithTextChildren | mount | 6705 | 6533 | 5000 | |
| SwatchColorPicker | mount | 13442 | 13477 | 5000 | |
| TagPicker | mount | 3399 | 3466 | 5000 | |
| TeachingBubble | mount | 104946 | 106836 | 5000 | |
| Text | mount | 1031 | 1058 | 5000 | |
| TextField | mount | 2095 | 2104 | 5000 | |
| ThemeProvider | mount | 1956 | 1947 | 5000 | |
| ThemeProvider | virtual-rerender | 1366 | 1370 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2734 | 2779 | 5000 | |
| Toggle | mount | 1418 | 1401 | 5000 | |
| buttonNative | mount | 686 | 689 | 5000 |
behowell
approved these changes
Oct 3, 2022
|
@sopranopillow after you described your repro I am able to repro in Safari 16 as well. |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 5, 2022
* master: (62 commits) chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458) chore(react-dialog): updates stories (microsoft#25070) refactor Progress to remove label and description slots (microsoft#25067) fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059) chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007) (docs): update Icon docs with examples (microsoft#24768) Split button/primary hc fix (microsoft#25066) chore(react-utilities): restricts trigger API types (microsoft#25044) Add utilities export @fluentui/style-utilities v8 (microsoft#25065) chore: migrate whole repo to webpack 5 (microsoft#24542) applying package updates BREAKING: refactor `useTable` to be composable (microsoft#24947) Added shims to shim packages (microsoft#25048) Add Progress SPEC (microsoft#24418) applying package updates chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055) fix(Button): Remove margin added to buttons by Safari (microsoft#25052) fix: Menu triggers no longer take focus when they are mounted (microsoft#25016) chore: deletes react-trigger package (microsoft#25042) Fixed a minor typo: immmediately => immediately (microsoft#25036) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* fix: Removing 2px margin that Safari adds to all buttons. * change file * updating snapshots * adding react-experiments snapshots
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
New Behavior
Note: this was verified in Safari 15.
Related Issue(s)
Fixes #19988