Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shims to shim packages #25048

Merged
merged 8 commits into from
Oct 4, 2022
Merged

Added shims to shim packages #25048

merged 8 commits into from
Oct 4, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Oct 3, 2022 •
edited
Loading

Note: This is the first step in a previously approved PR #25024 where the branch got messed up and couldn't be fixed.

Changes

  • moved shims into their migration packages

PR Notes

This is a big PR, but is almost all mechanical file moves with the rest being created through create-component.

Issues

Updates #24957

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Oct 3, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team as code owners October 3, 2022 17:17
@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 3, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 3, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 79.037 kB
24.059 kB
react-alert
Alert		 84.117 kB
21.07 kB
react-avatar
Avatar		 48.828 kB
13.842 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.796 kB
19.182 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.49 kB
7.489 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.278 kB
9.636 kB
react-button
CompoundButton		 43.303 kB
10.852 kB
react-button
MenuButton		 38.972 kB
10.536 kB
react-button
SplitButton		 46.418 kB
11.916 kB
react-button
ToggleButton		 52.145 kB
11.108 kB
react-card
Card - All		 67.17 kB
19.281 kB
react-card
Card		 62.852 kB
18.198 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.642 kB
24.19 kB
react-combobox
Dropdown (including child components)		 74.242 kB
24.089 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.209 kB
52.401 kB
react-components
react-components: FluentProvider & webLightTheme		 33.4 kB
11.008 kB
react-dialog
Dialog (including children components)		 82.438 kB
24.444 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.762 kB
7.706 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.806 kB
4.868 kB
react-menu
Menu (including children components)		 116.771 kB
35.786 kB
react-menu
Menu (including selectable components)		 119.84 kB
36.296 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-persona
Persona		 53.946 kB
15.225 kB
react-popover
Popover		 102.929 kB
31.542 kB
react-portal
Portal		 10.582 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-progress
Progress		 13.44 kB
5.247 kB
react-provider
FluentProvider		 15.761 kB
5.885 kB
react-radio
Radio		 36.39 kB
12.103 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.759 kB
10.064 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 33.342 kB
10.557 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.018 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.541 kB
14.646 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 8fd972011787b2dd48b6b75fb761f34c50334592

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 888fb67:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 3, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8fd972011787b2dd48b6b75fb761f34c50334592 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 3, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1320 1316 5000
Button mount 947 947 5000
FluentProvider mount 1579 1588 5000
FluentProviderWithTheme mount 621 630 10
FluentProviderWithTheme virtual-rerender 591 585 10
FluentProviderWithTheme virtual-rerender-with-unmount 624 625 10
MakeStyles mount 1909 1903 50000
SpinButton mount 2567 2538 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 3, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 174 158 1.1:1
GridMinimalPerf.default 332 307 1.08:1
ListWith60ListItems.default 638 589 1.08:1
TreeWith60ListItems.default 166 157 1.06:1
AlertMinimalPerf.default 278 265 1.05:1
AttachmentMinimalPerf.default 156 148 1.05:1
ImageMinimalPerf.default 383 365 1.05:1
InputMinimalPerf.default 1168 1114 1.05:1
LabelMinimalPerf.default 389 372 1.05:1
AvatarMinimalPerf.default 192 185 1.04:1
DropdownManyItemsPerf.default 693 665 1.04:1
ReactionMinimalPerf.default 384 369 1.04:1
CarouselMinimalPerf.default 477 461 1.03:1
HeaderMinimalPerf.default 348 338 1.03:1
HeaderSlotsPerf.default 760 738 1.03:1
PortalMinimalPerf.default 175 170 1.03:1
RadioGroupMinimalPerf.default 434 422 1.03:1
SegmentMinimalPerf.default 345 334 1.03:1
StatusMinimalPerf.default 685 668 1.03:1
IconMinimalPerf.default 655 635 1.03:1
BoxMinimalPerf.default 340 332 1.02:1
DividerMinimalPerf.default 354 347 1.02:1
DropdownMinimalPerf.default 2703 2658 1.02:1
MenuMinimalPerf.default 849 836 1.02:1
ProviderMergeThemesPerf.default 1318 1294 1.02:1
ProviderMinimalPerf.default 411 402 1.02:1
SplitButtonMinimalPerf.default 4509 4403 1.02:1
TooltipMinimalPerf.default 2375 2328 1.02:1
AttachmentSlotsPerf.default 1119 1108 1.01:1
ButtonOverridesMissPerf.default 1325 1315 1.01:1
ButtonSlotsPerf.default 549 545 1.01:1
ChatDuplicateMessagesPerf.default 270 267 1.01:1
FlexMinimalPerf.default 282 278 1.01:1
ListCommonPerf.default 605 601 1.01:1
MenuButtonMinimalPerf.default 1720 1704 1.01:1
SliderMinimalPerf.default 1604 1595 1.01:1
CardMinimalPerf.default 529 529 1:1
CheckboxMinimalPerf.default 2081 2079 1:1
DatepickerMinimalPerf.default 5768 5754 1:1
DialogMinimalPerf.default 786 788 1:1
EmbedMinimalPerf.default 3666 3663 1:1
FormMinimalPerf.default 369 370 1:1
PopupMinimalPerf.default 628 629 1:1
SkeletonMinimalPerf.default 332 331 1:1
TableManyItemsPerf.default 1875 1876 1:1
ChatMinimalPerf.default 717 727 0.99:1
LayoutMinimalPerf.default 351 353 0.99:1
ListMinimalPerf.default 516 519 0.99:1
RosterPerf.default 2109 2120 0.99:1
RefMinimalPerf.default 208 210 0.99:1
ToolbarMinimalPerf.default 912 924 0.99:1
TreeMinimalPerf.default 793 805 0.99:1
VideoMinimalPerf.default 710 715 0.99:1
AnimationMinimalPerf.default 531 541 0.98:1
ListNestedPerf.default 543 552 0.98:1
LoaderMinimalPerf.default 657 672 0.98:1
TableMinimalPerf.default 393 402 0.98:1
CustomToolbarPrototype.default 2708 2759 0.98:1
ChatWithPopoverPerf.default 357 369 0.97:1
TextMinimalPerf.default 339 354 0.96:1
ItemLayoutMinimalPerf.default 1161 1218 0.95:1
AccordionMinimalPerf.default 134 143 0.94:1
TextAreaMinimalPerf.default 458 489 0.94:1

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) October 3, 2022 18:02
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 3, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1405 1413 5000
Breadcrumb mount 3485 3434 1000
Checkbox mount 3188 3111 5000
CheckboxBase mount 2785 2785 5000
ChoiceGroup mount 5149 5234 5000
ComboBox mount 1481 1504 1000
CommandBar mount 11233 11197 1000
ContextualMenu mount 13135 13115 1000
DefaultButton mount 1610 1699 5000
DetailsRow mount 4230 4207 5000
DetailsRowFast mount 4337 4248 5000
DetailsRowNoStyles mount 4104 4082 5000
Dialog mount 3680 3638 1000
DocumentCardTitle mount 696 687 1000
Dropdown mount 3803 3776 5000
FocusTrapZone mount 2381 2400 5000
FocusZone mount 2396 2281 5000
GroupedList mount 62388 69973 2
GroupedList virtual-rerender 28983 29456 2
GroupedList virtual-rerender-with-unmount 108854 109491 2
GroupedListV2 mount 668 673 2
GroupedListV2 virtual-rerender 634 640 2
GroupedListV2 virtual-rerender-with-unmount 657 663 2
IconButton mount 2274 2290 5000
Label mount 843 884 5000
Layer mount 5091 5059 5000
Link mount 952 981 5000
MenuButton mount 1957 1957 5000
MessageBar mount 2779 2709 5000
Nav mount 3856 3848 1000
OverflowSet mount 1631 1676 5000
Panel mount 2980 2960 1000
Persona mount 1474 1494 1000
Pivot mount 1937 1961 1000
PrimaryButton mount 1812 1791 5000
Rating mount 8249 8247 5000
SearchBox mount 1766 1779 5000
Shimmer mount 3301 3370 5000
Slider mount 2432 2442 5000
SpinButton mount 5445 5515 5000
Spinner mount 929 943 5000
SplitButton mount 3623 3945 5000
Stack mount 1007 1031 5000
StackWithIntrinsicChildren mount 2732 2725 5000
StackWithTextChildren mount 5652 5685 5000
SwatchColorPicker mount 12337 12427 5000
TagPicker mount 3151 3123 5000
TeachingBubble mount 101193 100497 5000
Text mount 962 936 5000
TextField mount 1868 1867 5000
ThemeProvider mount 1790 1827 5000
ThemeProvider virtual-rerender 1275 1312 5000
ThemeProvider virtual-rerender-with-unmount 2551 2572 5000
Toggle mount 1308 1350 5000
buttonNative mount 649 659 5000

@GeoffCoxMSFT GeoffCoxMSFT merged commit 0afe50e into microsoft:master Oct 4, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 5, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
3e5d385 
* master: (62 commits)
  chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458)
  chore(react-dialog): updates stories (microsoft#25070)
  refactor Progress to remove label and description slots (microsoft#25067)
  fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059)
  chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007)
  (docs): update Icon docs with examples (microsoft#24768)
  Split button/primary hc fix (microsoft#25066)
  chore(react-utilities): restricts trigger API types (microsoft#25044)
  Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
  chore: migrate whole repo to webpack 5 (microsoft#24542)
  applying package updates
  BREAKING: refactor `useTable` to be composable (microsoft#24947)
  Added shims to shim packages (microsoft#25048)
  Add Progress SPEC (microsoft#24418)
  applying package updates
  chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055)
  fix(Button): Remove margin added to buttons by Safari (microsoft#25052)
  fix: Menu triggers no longer take focus when they are mounted (microsoft#25016)
  chore: deletes react-trigger package (microsoft#25042)
  Fixed a minor typo: immmediately => immediately (microsoft#25036)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@GeoffCoxMSFT @NotWoods
Added shims to shim packages (microsoft#25048)
930c9a6 
* Added shims to shim packages

* Fixing syncpack issues

* Added missing dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@micahgodbolt micahgodbolt micahgodbolt approved these changes

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
None yet
Projects
None yet
Milestone
October Project Cycle Q4 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoffCoxMSFT @fabricteam @micahgodbolt @khmakoto