Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utilities export @fluentui/style-utilities v8 #25065

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add utilities export @fluentui/style-utilities v8 #25065

merged 2 commits into from
Oct 4, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

Changes

  • Added Utilities.ts to export utilities/index for to avoid the top-level index side effect.

Issues

Updates #24393

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Oct 3, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested review from dzearing and a team as code owners October 3, 2022 23:15
@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 3, 2022
@GeoffCoxMSFT GeoffCoxMSFT changed the title Add utilities export @fluentui/style-utiltieis Add utilities export @fluentui/style-utilities v8 Oct 3, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0cc35c9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 3, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 97e3ebb627a8a24f805454fa0220f7e2827d3107 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 97e3ebb627a8a24f805454fa0220f7e2827d3107

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1205 1175 5000
Breadcrumb mount 2797 2803 1000
Checkbox mount 2647 2632 5000
CheckboxBase mount 2370 2357 5000
ChoiceGroup mount 4288 4245 5000
ComboBox mount 1234 1165 1000
CommandBar mount 9238 9256 1000
ContextualMenu mount 10145 10157 1000
DefaultButton mount 1360 1370 5000
DetailsRow mount 3369 3355 5000
DetailsRowFast mount 3409 3366 5000
DetailsRowNoStyles mount 3206 3196 5000
Dialog mount 2936 2949 1000
DocumentCardTitle mount 576 587 1000
Dropdown mount 3160 3151 5000
FocusTrapZone mount 1974 1957 5000
FocusZone mount 1924 1904 5000
GroupedList mount 47569 53076 2
GroupedList virtual-rerender 23360 23228 2
GroupedList virtual-rerender-with-unmount 82926 82923 2
GroupedListV2 mount 561 552 2
GroupedListV2 virtual-rerender 531 528 2
GroupedListV2 virtual-rerender-with-unmount 545 554 2
IconButton mount 1803 1811 5000
Label mount 748 763 5000
Layer mount 4098 4107 5000
Link mount 858 849 5000
MenuButton mount 1629 1603 5000
MessageBar mount 2359 2338 5000
Nav mount 3059 3071 1000
OverflowSet mount 1390 1404 5000
Panel mount 2477 2499 1000
Persona mount 1240 1217 1000
Pivot mount 1513 1481 1000
PrimaryButton mount 1492 1485 5000
Rating mount 6994 6977 5000
SearchBox mount 1509 1498 5000
Shimmer mount 2957 2908 5000
Slider mount 2111 2136 5000
SpinButton mount 4329 4314 5000
Spinner mount 828 817 5000
SplitButton mount 2834 2836 5000
Stack mount 901 900 5000
StackWithIntrinsicChildren mount 2241 2235 5000
StackWithTextChildren mount 4939 4917 5000
SwatchColorPicker mount 9574 10270 5000
TagPicker mount 2372 2328 5000
TeachingBubble mount 75700 75261 5000
Text mount 819 825 5000
TextField mount 1553 1550 5000
ThemeProvider mount 1440 1442 5000
ThemeProvider virtual-rerender 1145 1150 5000
ThemeProvider virtual-rerender-with-unmount 1984 1993 5000
Toggle mount 1131 1127 5000
buttonNative mount 525 528 5000

@GeoffCoxMSFT GeoffCoxMSFT merged commit 0a36b54 into microsoft:master Oct 4, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 5, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
3e5d385 
* master: (62 commits)
  chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458)
  chore(react-dialog): updates stories (microsoft#25070)
  refactor Progress to remove label and description slots (microsoft#25067)
  fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059)
  chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007)
  (docs): update Icon docs with examples (microsoft#24768)
  Split button/primary hc fix (microsoft#25066)
  chore(react-utilities): restricts trigger API types (microsoft#25044)
  Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
  chore: migrate whole repo to webpack 5 (microsoft#24542)
  applying package updates
  BREAKING: refactor `useTable` to be composable (microsoft#24947)
  Added shims to shim packages (microsoft#25048)
  Add Progress SPEC (microsoft#24418)
  applying package updates
  chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055)
  fix(Button): Remove margin added to buttons by Safari (microsoft#25052)
  fix: Menu triggers no longer take focus when they are mounted (microsoft#25016)
  chore: deletes react-trigger package (microsoft#25042)
  Fixed a minor typo: immmediately => immediately (microsoft#25036)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@GeoffCoxMSFT @NotWoods
Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
5fa0e4f 
* Added export of utilities to avoid sideeffect from index

* yarn change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahgodbolt micahgodbolt micahgodbolt approved these changes

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Package: styling
Projects
None yet
Milestone
October Project Cycle Q4 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoffCoxMSFT @fabricteam @micahgodbolt @msft-fluent-ui-bot