Stgum/q fixes #2932
Merged
Stgum/q fixes #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added DialogContextMemoryScope * removed setMemory implementation in dialog context memory scope Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: Steven Gum <[email protected]>
* other minor cleanup in bf-connector
* Switch to ubuntu vmimage * Tweak sed commands * Add ubuntu to the other builds * Add var NoPublish * Fix NoPublish logic * Rename var to DoNotPublishPackages * Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch. * Fix Package Names task Co-authored-by: Steven Gum <[email protected]>
stevengum
requested review from
axelsrz,
carlosscastro,
johnataylor and
a team
as code owners
stevengum
added a commit
that referenced
this pull request
Oct 21, 2020
* Properly use RoleTypes * Add skill roletype, cast to bandaid compiler bug? * Port anonymous skill changes * ChannelServiceHandler test * AppCredentials tests * SkillsValidation tests * Fix ClaimsIdentity constructor * Add comment describing `isAuthenticated` override * Stgum/q fixes (#2932) * [PORT] DialogContextMemoryScope (#2895) * added DialogContextMemoryScope * removed setMemory implementation in dialog context memory scope Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: Steven Gum <[email protected]> * exclude browser*.js from bf-connector .nycrc * other minor cleanup in bf-connector * Change vmImage to ubuntu for all JS pipelines (#2931) * Switch to ubuntu vmimage * Tweak sed commands * Add ubuntu to the other builds * Add var NoPublish * Fix NoPublish logic * Rename var to DoNotPublishPackages * Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch. * Fix Package Names task Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: BruceHaley <[email protected]> * Fix skill validation tests * Fix assert message * Fix test label * Add extra assertions Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: BruceHaley <[email protected]>
joshgummersall
added a commit
that referenced
this pull request
Oct 21, 2020
* Properly use RoleTypes * Add skill roletype, cast to bandaid compiler bug? * Port anonymous skill changes * ChannelServiceHandler test * AppCredentials tests * SkillsValidation tests * Fix ClaimsIdentity constructor * Update/Delete activities from skills Fixes #1995 * Add comment describing `isAuthenticated` override * Fake response with activityId * Stgum/q fixes (#2932) * [PORT] DialogContextMemoryScope (#2895) * added DialogContextMemoryScope * removed setMemory implementation in dialog context memory scope Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: Steven Gum <[email protected]> * exclude browser*.js from bf-connector .nycrc * other minor cleanup in bf-connector * Change vmImage to ubuntu for all JS pipelines (#2931) * Switch to ubuntu vmimage * Tweak sed commands * Add ubuntu to the other builds * Add var NoPublish * Fix NoPublish logic * Rename var to DoNotPublishPackages * Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch. * Fix Package Names task Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: BruceHaley <[email protected]> * Fix skill validation tests * Fix assert message * Fix test label * Cleanup Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: BruceHaley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Specific Changes
Testing